[release/10.0] Composite ML-DSA Draft 12 and 13 updates (#120601, #120961)#121555
Merged
artl93 merged 3 commits intorelease/10.0from Nov 14, 2025
Merged
[release/10.0] Composite ML-DSA Draft 12 and 13 updates (#120601, #120961)#121555artl93 merged 3 commits intorelease/10.0from
artl93 merged 3 commits intorelease/10.0from
Conversation
[Draft 12](https://datatracker.ietf.org/doc/html/draft-ietf-lamps-pq-composite-sigs-12) of the Composite ML-DSA spec now requires the parameters to be present for `ECPrivateKey`. This PR implements these changes in our managed Composite ML-DSA implementation. --------- Co-authored-by: Kevin Jones <[email protected]>
Copilot
AI
changed the title
[WIP] Backport changes from PR 120601 to release/10.0 branch
Backport #120601: Require parameters in ECPrivateKey for Composite ML-DSA
Nov 12, 2025
PranavSenthilnathan
changed the title
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR backports Draft 12 specification changes for Composite ML-DSA that mandate the presence of the parameters field in ECPrivateKey structures. Previously, per Draft 8, parameters were omitted; now they must be present with the correct named curve OID for spec conformance.
- Updates ECPrivateKey serialization to include mandatory parameters field with context-specific tag [0]
- Adds validation to reject keys with missing, wrong, implicit, or explicit curve parameters
- Updates expected key sizes in tests to match Draft 12 spec Table 4
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| CompositeMLDsaAlgorithm.cs | Calculates parameter field size for each EC curve variant (P256/P384/P521/brainpool) based on their DER-encoded OID sizes |
| CompositeMLDsaManaged.ECDsa.cs | Validates parameters presence and curve match on import; writes parameters field with correct ASN.1 tag on export |
| CompositeMLDsaManaged.cs | Updates spec reference comments from draft-08 to draft-12 |
| CompositeMLDsaTestHelpers.cs | Updates expected private key size bounds to exact values per Draft 12 Table 4 for all ECDSA variants |
| CompositeMLDsaFactoryTests.cs | Adds comprehensive test coverage for parameter validation: wrong curve, missing parameters, implicit curves, explicit curves |
This was referenced Nov 12, 2025
Open
PranavSenthilnathan
requested changes
Nov 13, 2025
Update to draft 13 of Composite ML-DSA. Changelog: lamps-wg/draft-composite-sigs@draft-ietf-lamps-pq-composite-sigs-12...main
Contributor
Author
Cherry-picked commit efb3990 which updates to Draft 13 of Composite ML-DSA. All 1,015 CompositeMLDsa tests pass. Changes include:
Commit: 6970266 Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[release/10.0] Require parameters in ECPrivateKey for Composite ML-DSA (#120601)
[release/10.0] Composite ML-DSA Draft 12 and 13 updates (#120601, #120961)
Nov 13, 2025
PranavSenthilnathan
approved these changes
Nov 13, 2025
bartonjs
approved these changes
Nov 13, 2025
Member
|
/ba-g android timeouts and #70450 |
artl93
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #120601 and #120961 to release/10.0
Description
Backports Draft 12 and Draft 13 spec changes for Composite ML-DSA. This PR combines two related updates:
Draft 12 changes (#120601):
CompositeMLDsaAlgorithm.cs: Calculate parameters field size for EC curves (P256/P384/P521/brainpool variants)CompositeMLDsaManaged.ECDsa.cs: Validate parameters presence and curve match; write parameters with context-specific tag [0]CompositeMLDsaManaged.cs: Update spec references from draft-08 to draft-12Draft 13 changes (#120961):
Oids.cs: Update all Composite ML-DSA OID constants to new rangeCompositeMLDsaManaged.cs: Add "ECDSA" to domain separation strings (e.g., "COMPSIG-MLDSA65-P256-SHA512" → "COMPSIG-MLDSA65-ECDSA-P256-SHA512")Customer Impact
Without these fixes, Composite ML-DSA keys generated in .NET 10 would not conform to Draft 12 and Draft 13 of the IETF spec, causing interoperability failures with other implementations following the updated standards.
Regression
No. This updates implementation to match spec evolution from Draft 8 to Draft 13.
Testing
All 1,015 CompositeMLDsa tests pass. Added test coverage for:
Risk
Low. Changes are confined to Composite ML-DSA implementation (preview feature). Validates existing behavior is maintained while adding required spec compliance. Breaking changes are intentional and necessary for spec conformance.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.