Allow PublishReadyToRunEmitSymbols to be overridden#121406
Allow PublishReadyToRunEmitSymbols to be overridden#121406kotlarmilos merged 4 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @steveisok, @akoeplinger |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the PublishReadyToRunEmitSymbols property initialization to respect user-provided values. Previously, the property was unconditionally set to false for Apple platforms (iOS, tvOS, macOS Catalyst), which prevented users from overriding this behavior.
Key Changes:
- Modified the condition for
PublishReadyToRunEmitSymbolsto only set it tofalsewhen the property hasn't been explicitly set by the user
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I think arcade overrides PublishReadyToRunEmitSymbols in https://github.com/dotnet/arcade/blob/7d717a49d570577936361c14de38bf61271aa274/src/Microsoft.DotNet.SharedFramework.Sdk/targets/sharedfx.targets#L10 iOS build is failing with the System.NotImplementedException: iOS |
|
We can change arcade to not forcibly override it. |
|
Arcade PR here: dotnet/arcade#16281 |
|
/ba-g #121838 |
Description
This PR updates PublishReadyToRunEmitSymbols to allow it to be overridden. It aligns the behavior with the SDK mirror.