Fix interpreted synchronized methods#121020
Merged
janvorli merged 1 commit intoOct 23, 2025
Merged
Conversation
The InterpCompiler::CreateBasicBlocks was comparing incorrect offset with m_ILCodeSizeFromILHeader when checking when to convert CEE_RET to CEE_LEAVE. The m_currentILOffset it was using was uninitialized, so sometimes the comparison passed, sometimes not based on the random value in the m_currentILOffset.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the interpreter's basic block creation for synchronized methods where an uninitialized variable was being used to determine when to convert CEE_RET instructions to CEE_LEAVE instructions. The fix ensures the correct offset variable is used in the comparison.
- Replaces use of uninitialized
m_currentILOffsetwith the properly initializedinsOffsetvariable in the condition check
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
kg
reviewed
Oct 23, 2025
kg
approved these changes
Oct 23, 2025
Member
|
Oops. Sorry about that. |
davidwrighton
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
InterpCompiler::CreateBasicBlockswas comparing incorrect offset withm_ILCodeSizeFromILHeaderwhen checking when to convertCEE_RETtoCEE_LEAVE. Them_currentILOffsetit was using was uninitialized, so sometimes the comparison passed, sometimes not based on the random value in them_currentILOffset.