JIT: Switch GS cookie check to use r9 to account for Swift#120745
Merged
Conversation
The Swift calling convention can return values in r8 so switch the GS cookie check to use r9 for its temporary register.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the JIT's GS cookie check on x64 platforms to use register r9 instead of r8 as a temporary register. This change is necessary because the Swift calling convention can return values in r8, and using it for the GS cookie check would overwrite those return values.
Key Changes
- Changed the temporary register for GS cookie checks from r8 to r9 on AMD64 platforms
- Updated the corresponding comment to reflect support for Swift calling convention
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
AndyAyersMS
approved these changes
Oct 17, 2025
Member
Author
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Swift calling convention can return values in r8 so switch the GS cookie check to use r9 for its temporary register.
Fix #120557