Skip to content

[release/8.0] Enable hotfix branding#120453

Merged
steveisok merged 3 commits intodotnet:release/8.0from
mmitche:hotfix-branding
Dec 4, 2025
Merged

[release/8.0] Enable hotfix branding#120453
steveisok merged 3 commits intodotnet:release/8.0from
mmitche:hotfix-branding

Conversation

@mmitche
Copy link
Member

@mmitche mmitche commented Oct 6, 2025

Enable the ability to produce non-stabilized hotfix servicing builds.

@mmitche mmitche requested a review from marek-safar as a code owner October 6, 2025 21:43
Copilot AI review requested due to automatic review settings October 6, 2025 21:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables hotfix branding for .NET 8.0 servicing builds by introducing a more flexible build property system. The change allows non-stabilized hotfix servicing builds to be produced alongside traditional servicing builds.

Key changes:

  • Introduces IsServicingBuild property to replace hardcoded PreReleaseVersionLabel checks
  • Expands servicing build detection to include both 'servicing' and 'hotfix' labels
  • Changes default package stabilization behavior from true to false

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
eng/Versions.props Introduces IsServicingBuild property and updates package stabilization default
src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj Updates InformationalVersion condition to use new property
src/coreclr/nativeaot/Directory.Build.props Updates InformationalVersion condition to use new property
src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj Updates InformationalVersion condition to use new property
src/coreclr/.nuget/Directory.Build.targets Updates StableVersion condition to use new property
src/coreclr/.nuget/Directory.Build.props Updates shipping property condition to use new property
eng/packaging.targets Updates multiple packaging conditions to use new property
Directory.Build.targets Updates InformationalVersion condition to use new property

@steveisok
Copy link
Member

@mmitche failures do not look related. Good to go?

@mmitche
Copy link
Member Author

mmitche commented Dec 4, 2025

@mmitche failures do not look related. Good to go?

yes

@steveisok steveisok self-requested a review December 4, 2025 16:59
@steveisok steveisok added the Servicing-approved Approved for servicing release label Dec 4, 2025
@steveisok steveisok enabled auto-merge (squash) December 4, 2025 17:00
@steveisok
Copy link
Member

@steveisok steveisok merged commit 34de5e1 into dotnet:release/8.0 Dec 4, 2025
186 of 190 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants