Avoid some allocations in BitVector256#120427
Merged
tannergooding merged 1 commit intoOct 23, 2025
Merged
Conversation
github-actions
Bot
added
the
needs-area-label
dotnet-policy-service
Bot
added
the
community-contribution
MihaZupan
added
area-System.Memory
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-memory |
Member
|
These methods are only called by the debugger when you hover over a SearchValues instance, so the allocation doesn't matter here. |
Contributor
Author
Maybe it's of lesser importance, but it's still eight unnecessary allocations (the list and seven internal arrays). |
xtqqczze
force-pushed
the
avoidallocations-BitVector256
branch
from
e44f7dd to
f9dd64a
Compare
tannergooding
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid eight unnecessary allocations (the list, plus seven internal arrays due to resizing).