[browser] Use WebAssembly SDK for runtime tests #120330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraf
added
arch-wasm
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Oct 3, 2025
Open
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Nov 29, 2025
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
radekdoulik
approved these changes
Dec 4, 2025
Member
radekdoulik
left a comment
radekdoulik
left a comment
There was a problem hiding this comment.
Nice to see that simplified, thank you. Looking forward to coreclr changes on top of that.
LGTM, does any documentation need change too? Doesn't need to be done in this PR though.
Member
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Extended set of Smoke_AOT tests passed |
Member
Author
I have change what I encounter on the road. I think we need to do some more house cleaning when we introduce a native build for CoreCLR. |
Member
Author
|
/ba-g Wasm.Build.Tests and CoreCLR failures are not related |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WasmAppBuilderand targets around itminimal-configsample as we have a proper way to generate bundler-friendly boot configLinkContentToWwwroottask to manipulate incoming@(Content)and$(PublishDir)files to the shape that can be consumed by SWA and accessible at some URL (in the wwwroot)WasmInvariantGlobalizationWasmRunWasmOptFixes #103025
TODO
<Content Link="..."copy the assembly to the publish output early enough, so that it gets picked up toWasmAssembliesToBundleand so the AOT compiler gets itNetCoreServerandRemoteLoopServerGetCurrentProjectBuildStaticWebAssetItemsWasmFilesToIncludeInFileSystem- We needed coreVfs for runtimeConfig, but we have that solved now by embedding it into the boot manifest. I think we can drop coreVfs. The challenge is that VFS items hastargetPathas well, so SWA standard properties aren't enoughIncludeSatelliteAssembliesInVFS(it's not used anywhere anymore)browser-wasm linux Release LibraryTests_EAT(aka AOTonHelix)RunSmokeTestsOnly=trueRunHighAOTResourceRequiringTestsOnly=trueProxyProjectForAOTOnHelix.projis usingWasmApp.LocalBuild.props/targetsPrepareForRun(DependsOn) for SWAComputeAndCopyFilesToPublishDirectoryfor SWAWasmAppDir<OutputType Condition="'$(OutputType)' == ''">exe</OutputType>inMicrosoft.NET.Sdk.WebAssembly.Browser.propsis too relaxed as at the point the default value oflibraryis already supplied by general SDK propsStartupHookForFunctionalTest.csprojWasm.Advanced.Sample.csprojhasWasmAssembliesToBundleitem is emptyStartupHookForFunctionalTestconflicting SWAMicrosoft.CSharp.wasmInvariantGlobalizationis empty, results in_WasmInvariantGlobalization=trueWasmIncludeFullIcuDataWasmAppBuilderand related targetsWasmExtraFilesToDeployfrom tests<WasmEnvironmentVariable Include="DOTNET_DiagnosticPorts" Value="$(DiagnosticPorts)" Condition="'$(DiagnosticPorts)' != ''"/>