[release/10.0] Fix ResourceUpdater.Dispose() #120136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @vitek-karas, @agocke |
agocke
approved these changes
Sep 26, 2025
sbomer
approved these changes
Sep 26, 2025
agocke
added
Servicing-approved
Member
|
/backport to release/10.0-rc2 |
Contributor
Author
|
Started backporting to release/10.0-rc2: https://github.com/dotnet/runtime/actions/runs/18139609347 |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #120029 to release/10.0
The apphost ResourceUpdater doesn't dispose of the PEReader when leaveOpen is true, but the leaveOpen should only apply to the FileStream passed to the constructor. The PEReader is not accessible from the creator and cannot be disposed of elsewhere. This led to some race conditions in the SDK which caused the bundler to later fail to open the apphost.
Context: dotnet/sdk#50784
Customer Impact
Found in SDK tests.
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
There is a unit test to verify the disposal behavior. The race condition appeared in a few sdk tests after updates to host writer.
Risk
Low. This fixes a simple Dispose bug in a codepath that wasn't exercised until recently.
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.