Instrumentation for EnvironmentVariablesTest.BindingDoesNotThrowIfReloadedDuringBinding test#120134
Merged
jkotas merged 2 commits intodotnet:mainfrom Sep 26, 2025
Merged
Instrumentation for EnvironmentVariablesTest.BindingDoesNotThrowIfReloadedDuringBinding test#120134jkotas merged 2 commits intodotnet:mainfrom
jkotas merged 2 commits intodotnet:mainfrom
Conversation
…oadedDuringBinding test Contributes to dotnet#109904
github-actions
bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds instrumentation to the BindingDoesNotThrowIfReloadedDuringBinding test method to help diagnose intermittent failures related to issue #109904. The change wraps the existing test logic in a try-catch block that triggers a fail-fast crash dump when a NullReferenceException occurs.
- Wraps existing test logic in exception handling to capture crash dumps for debugging
- Adds fail-fast instrumentation specifically for NullReferenceException scenarios
- Extracts original test logic into a separate worker method
...es/Microsoft.Extensions.Configuration.EnvironmentVariables/tests/EnvironmentVariablesTest.cs
Show resolved
Hide resolved
jkotas
added
area-Extensions-Configuration
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration |
tarekgh
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #109904