Skip to content

Non-zero result of Vector3.Cross with parallel vectors#119438

Merged
tannergooding merged 3 commits intodotnet:mainfrom
pedrobsaila:114361
Sep 8, 2025
Merged

Non-zero result of Vector3.Cross with parallel vectors#119438
tannergooding merged 3 commits intodotnet:mainfrom
pedrobsaila:114361

Conversation

@pedrobsaila
Copy link
Contributor

Fixes #114361

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 7, 2025
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Co-authored-by: Tanner Gooding <[email protected]>
@tannergooding tannergooding merged commit 446ca5b into dotnet:main Sep 8, 2025
141 of 144 checks passed
@tannergooding
Copy link
Member

/backport to release/10.0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

@tannergooding
Copy link
Member

tannergooding commented Sep 11, 2025

Just noting this shows up as a 3ns (13%) regression in the Matrix4x4.CreateLookAt benchmark.

This is ultimately acceptable and likely non impactful to real world workloads, but it may be something some users care about for some scenarios and where they will need to roll their own alternative.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Numerics community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-zero result of Vector3.Cross with parallel vectors

2 participants