[release/10.0] [wasm] Use lightweight marshal for enums #119296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Larry Ewing <[email protected]>
…pTest.cs Co-authored-by: Copilot <[email protected]>
github-actions
bot
requested review from
ilonatommy,
maraf,
steveisok and
vitek-karas
as code owners
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing |
pavelsavara
approved these changes
Sep 3, 2025
lewing
approved these changes
Sep 3, 2025
jeffschwMSFT
approved these changes
Sep 3, 2025
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we can merge when ready
jeffschwMSFT
added
Servicing-approved
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #118991 to release/10.0
/cc @maraf
Customer Impact
#115780
Users with workload installed might get invalid build/publish output if there code uses enums in pinvokes.
Regression
Kind of. The #112981 fixed how we evaluate
DisableRuntimeMarshallingattribute, but runtime bits were missing case for marshalling enums.Testing
Automated tests.
Risk
Low. Affected use-case is covered with tests.