[release/10.0] [browser] Append uniqueness to webcil temp path & move instead of copy #119258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraf
added
Servicing-consider
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing |
jeffschwMSFT
approved these changes
Sep 2, 2025
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. please get a code review. we can merge when ready
jeffschwMSFT
added
Servicing-approved
lewing
approved these changes
Sep 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #119059 to release/10.0
/cc @maraf
Customer Impact
dotnet/aspnetcore#61987
If customers build Blazor based application in parallel (build whole solution or multi-target) there is possibility that a long running target run in parallel and try to write to the same files. This PR reduces the probability.
Regression
Testing
Existing tests cover the conversion to webcil format and integration into the whole build. Manual tests have been done regarding the parallel build execution.
Risk
Low.