Merged
Conversation
bartonjs
reviewed
Aug 28, 2025
...es/Common/tests/System/Security/Cryptography/AlgorithmImplementations/DSA/DSAImportExport.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/tests/DSACreateTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/tests/SignatureDescriptionTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/tests/SignatureDescriptionTests.cs
Show resolved
Hide resolved
...curity.Cryptography/tests/X509Certificates/CertificateCreation/PrivateKeyAssociationTests.cs
Outdated
Show resolved
Hide resolved
vcsjones
added
breaking-change
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes Digital Signature Algorithm (DSA) support from macOS platforms in the .NET cryptography libraries. The change affects the native Apple cryptography implementation and updates test files to properly handle the absence of DSA support.
Key changes include:
- Removal of DSA-specific enum values and code from the native Apple cryptography implementation
- Updates to test attributes to use conditional testing based on platform DSA support
- Deletion of DSA SecurityTransforms implementation files
- Updates to platform support detection to exclude Apple platforms from DSA support
Reviewed Changes
Copilot reviewed 49 out of 49 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/native/libs/System.Security.Cryptography.Native.Apple/pal_signverify.h |
Removes DSA enum value and updates function documentation |
src/native/libs/System.Security.Cryptography.Native.Apple/pal_signverify.c |
Removes DSA-specific transform functions and conditional logic |
src/native/libs/System.Security.Cryptography.Native.Apple/pal_seckey.h |
Updates documentation to remove DSA references |
src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/X509Certificates/X509Pal.macOS.cs |
Removes DSA public key decoding logic |
src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/X509Certificates/X509CertificateLoader.macOS.cs |
Removes DSA key handling and import logic |
src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/X509Certificates/AppleCertificatePal.Keys.macOS.cs |
Replaces DSA implementation with PlatformNotSupportedException |
src/libraries/System.Security.Cryptography/src/System.Security.Cryptography.csproj |
Removes DSA SecurityTransforms source files and adds NotSupported implementation |
| Multiple test files | Updates test attributes from SkipOnPlatform to ConditionalFact/ConditionalTheory using PlatformSupport.IsDSASupported |
src/libraries/Common/tests/System/Security/Cryptography/PlatformSupport.cs |
Adds IsDSASupported property excluding Apple platforms |
src/libraries/Common/src/System/Security/Cryptography/DSASecurityTransforms.*.cs |
Complete removal of DSA SecurityTransforms implementation files |
src/libraries/System.Security.Cryptography/tests/PKCS1MaskGenerationMethodTest.cs
Show resolved
Hide resolved
dotnet-policy-service
bot
added
the
needs-breaking-change-doc-created
Contributor
|
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
…o DSASecurityTransforms
bartonjs
reviewed
Aug 29, 2025
src/libraries/System.Security.Cryptography.Pkcs/tests/SignedCms/SignedCmsTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Pkcs/tests/SignedCms/SignerInfoTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Xml/tests/Samples/SigningVerifyingX509Cert.cs
Outdated
Show resolved
Hide resolved
bartonjs
approved these changes
Aug 29, 2025
3 tasks
vcsjones
removed
the
needs-breaking-change-doc-created
Member
Author
|
Breaking change doc: dotnet/docs#48201 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes DSA (FF-DSA) from macOS.
Closes #71738
Fixes #118107