[Socket] Fix expected exception type#118403
Merged
ManickaP merged 1 commit intodotnet:mainfrom Aug 6, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a test that was expecting the wrong exception type when attempting to disconnect a socket that isn't connected. The change corrects the expected exception from InvalidOperationException to SocketException and removes the ActiveIssue attribute that was tracking this problem.
Key Changes
- Updates test expectation to match actual socket behavior
- Removes ActiveIssue tracking since the issue is now resolved
Comments suppressed due to low confidence (1)
src/libraries/System.Net.Sockets/tests/FunctionalTests/DisconnectTest.cs:79
- The test method name should be updated to reflect the correct exception type. Consider renaming to
Disconnect_NotConnected_ThrowsSocketExceptionto match the actual behavior being tested.
public async Task Disconnect_NotConnected_ThrowsSocketException(bool reuseSocket)
Contributor
|
Tagging subscribers to this area: @dotnet/ncl |
CarnaViire
approved these changes
Aug 5, 2025
liveans
approved these changes
Aug 5, 2025
This was referenced Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118314