[System.Management] Skip DateTime_RoundTrip test for corefx implementation#118369
[System.Management] Skip DateTime_RoundTrip test for corefx implementation#118369jeffhandley merged 1 commit intodotnet:mainfrom
Conversation
corefx is the name of .NET Core Libraries, you want to say .NET Framework implementation
what about the other 2k usages of [ActiveIssue] in the repo? you shouldn't care for it in this single instance |
You are right, it is worth changing the term "corefx" to ".NET Framework". I was mistaken in my comment. Initially, it pointed to the root of the issue, which lay in corefx repository.
I believe this is a good practice. Removing the ActiveIssueAttribute and leaving the exception seems like a bad idea because it leaves no reference to the issue. |
i was suggesting to do the opposite, remove the excessive condition |
|
Tagging subscribers to this area: @dotnet/area-system-management |
Contributing towards #118321
Added a check for the framework version to avoid a test that is known in advance to fail for the .netstandard target.
Regarding the additional condition check besides ActiveIssue, I noticed that xunit-console does not recognize the attribute and launches the test. Therefore, a separate condition check is required.