[QUIC] Do async validation only from > 2.4, i.e. 2.4.1+#118339
Merged
ManickaP merged 1 commit intodotnet:mainfrom Aug 4, 2025
Merged
[QUIC] Do async validation only from > 2.4, i.e. 2.4.1+#118339ManickaP merged 1 commit intodotnet:mainfrom
ManickaP merged 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses QUIC test timeouts on macOS by adjusting the version check for async certificate validation support. The change is a workaround for a known MsQuic issue that affects version 2.4 but is resolved in later versions.
Key changes:
- Modified the version comparison for async certificate validation from
>=to>for MsQuic version 2.4 - Updated the comment formatting for consistency
Contributor
|
Tagging subscribers to this area: @dotnet/ncl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OSX QUIC timeouts are likely an instance of microsoft/msquic#4132.
On OSX, We're using MsQuic at this commit: microsoft/msquic@e0385b0 build from main (therefore having version of the next release - 2.4).
Historically, the above mentioned issue had a fix by that time: microsoft/msquic#4145
Unfortunately, the were at least 2 follow ups it seems:
Which are not part of the binaries with which we're testing.
TL;DR This should get fixed by new MsQuic, i.e. with #114912
This is an alternative which changes the async cert validation condition to
>in here:runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicApi.cs
Line 66 in 02596ba
Note that both Windows and latest Linux MsQuic binaries are 2.4.8 so this shouldn't have any effect on customers.
Fixes #107761
Fixes #105177
Fixes #103482
Fixes #104426