EC-DSA Composite ML-DSA for net8+#118232
Merged
PranavSenthilnathan merged 7 commits intodotnet:mainfrom Aug 4, 2025
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements EC-DSA (Elliptic Curve Digital Signature Algorithm) support for Composite ML-DSA algorithms on .NET 8+. The implementation adds EC-DSA as a second component alongside ML-DSA for quantum-resistant cryptographic schemes.
- Adds a new
CompositeMLDsaManaged.ECDsa.csfile implementing the EC-DSA component for Composite ML-DSA - Updates algorithm metadata to include specific curve and hash algorithm parameters for EC-DSA variants
- Enhances test coverage with additional validation scenarios and cross-algorithm tests
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| System.Security.Cryptography.csproj | Adds the new ECDsa component file to the build |
| Microsoft.Bcl.Cryptography.csproj | Adds the new ECDsa component file to the BCL package |
| CompositeMLDsaTestsBase.cs | Updates test methods to properly handle variable signature sizes and adds missing test scenarios |
| CompositeMLDsaTestHelpers.cs | Adds SEC curve distinction and improves algorithm parameter handling |
| CompositeMLDsaFactoryTests.cs | Adds comprehensive tests for ECDsa key import validation and cross-algorithm error scenarios |
| CompositeMLDsaManaged.cs | Updates algorithm metadata with specific ECDsa parameters and removes placeholder implementation |
| CompositeMLDsaManaged.RSA.cs | Adds key size validation for RSA component imports |
| CompositeMLDsaManaged.ECDsa.cs | New file implementing full ECDsa component with key generation, import/export, and signing/verification |
src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaManaged.RSA.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
bartonjs
reviewed
Jul 31, 2025
src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaManaged.ECDsa.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaManaged.ECDsa.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaManaged.ECDsa.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaManaged.ECDsa.cs
Outdated
Show resolved
Hide resolved
.../Security/Cryptography/AlgorithmImplementations/CompositeMLDsa/CompositeMLDsaFactoryTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaManaged.ECDsa.cs
Outdated
Show resolved
Hide resolved
...tem/Security/Cryptography/AlgorithmImplementations/CompositeMLDsa/CompositeMLDsaTestsBase.cs
Show resolved
Hide resolved
src/libraries/Microsoft.Bcl.Cryptography/src/Microsoft.Bcl.Cryptography.csproj
Outdated
Show resolved
Hide resolved
This was referenced Jul 31, 2025
bartonjs
approved these changes
Aug 1, 2025
src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaManaged.ECDsa.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaManaged.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaManaged.ECDsa.cs
Outdated
Show resolved
Hide resolved
This was referenced Aug 2, 2025
bartonjs
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.NETFramework requires more refactoring so I'm planning on doing it in a separate PR
Contributes to #116998