Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames "NDirect" terminology to "PInvoke" throughout the codebase to improve clarity and consistency. NDirect was an older term used internally to refer to Platform Invoke (P/Invoke) functionality for calling native code from managed code.
- Renames classes, methods, and variables from NDirect* to PInvoke*
- Updates comments and documentation to use PInvoke terminology
- Maintains the same functionality while improving code readability
Reviewed Changes
Copilot reviewed 93 out of 93 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Multiple .cpp/.h files | Rename NDirectMethodDesc to PInvokeMethodDesc and related methods |
| Assembly files | Update function names from NDirectImportThunk to PInvokeImportThunk |
| Header files | Rename class declarations and type definitions |
| Documentation/comments | Update terminology from NDirect to PInvoke throughout |
src/libraries/System.Private.CoreLib/src/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/PrecodeStubs_Common.cs
Outdated
Show resolved
Hide resolved
Contributor
|
Tagging subscribers to this area: @mangod9 |
Member
Author
|
The codebase has been using mix of both names that just does not look great.
|
…er.Contracts/Contracts/PrecodeStubs_Common.cs Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
This was referenced Jul 31, 2025
Member
|
/cc @dotnet/dotnet-diag |
Member
|
Failures are #118246 |
This was referenced Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.