Use IsAotCompatible for libraries#118149
Merged
sbomer merged 3 commits intodotnet:mainfrom Jul 30, 2025
Merged
Conversation
github-actions
bot
added
the
needs-area-label
This was referenced Jul 29, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes AOT (Ahead-of-Time) compilation configuration in .NET libraries by replacing the deprecated EnableAOTAnalyzer property with the new IsAotCompatible property. This change ensures that metadata from PR #118008 will be properly included in the libraries.
Key Changes:
- Replaces
EnableAOTAnalyzerwithIsAotCompatibleacross all library project files - Updates the default configuration in Directory.Build.props to use the new property
- Maintains the same AOT compatibility settings (true/false values) for each library
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/Directory.Build.props | Updates default AOT configuration to use IsAotCompatible instead of EnableAOTAnalyzer |
| src/libraries/Microsoft.CSharp/src/Microsoft.CSharp.csproj | Changes EnableAOTAnalyzer=true to IsAotCompatible=true |
| src/libraries/Microsoft.Extensions.DependencyInjection.Specification.Tests/src/Microsoft.Extensions.DependencyInjection.Specification.Tests.csproj | Changes EnableAOTAnalyzer=false to IsAotCompatible=false |
| src/libraries/System.ComponentModel.Composition/src/System.ComponentModel.Composition.csproj | Changes EnableAOTAnalyzer=false to IsAotCompatible=false |
| src/libraries/System.Composition.Hosting/src/System.Composition.Hosting.csproj | Changes EnableAOTAnalyzer=false to IsAotCompatible=false |
| src/libraries/System.Composition.Runtime/src/System.Composition.Runtime.csproj | Changes EnableAOTAnalyzer=false to IsAotCompatible=false |
| src/libraries/System.Composition.TypedParts/src/System.Composition.TypedParts.csproj | Changes EnableAOTAnalyzer=false to IsAotCompatible=false |
| src/libraries/System.Configuration.ConfigurationManager/src/System.Configuration.ConfigurationManager.csproj | Changes EnableAOTAnalyzer=false to IsAotCompatible=false |
| src/libraries/System.Data.Odbc/src/System.Data.Odbc.csproj | Changes EnableAOTAnalyzer=false to IsAotCompatible=false |
| src/libraries/System.Data.OleDb/src/System.Data.OleDb.csproj | Changes EnableAOTAnalyzer=false to IsAotCompatible=false |
| src/libraries/System.DirectoryServices.AccountManagement/src/System.DirectoryServices.AccountManagement.csproj | Changes EnableAOTAnalyzer=false to IsAotCompatible=false |
| src/libraries/System.DirectoryServices.Protocols/src/System.DirectoryServices.Protocols.csproj | Changes EnableAOTAnalyzer=false to IsAotCompatible=false |
| src/libraries/System.DirectoryServices/src/System.DirectoryServices.csproj | Changes EnableAOTAnalyzer=false to IsAotCompatible=false |
| src/libraries/System.Reflection.Context/src/System.Reflection.Context.csproj | Changes EnableAOTAnalyzer=false to IsAotCompatible=false |
| src/libraries/System.Reflection.MetadataLoadContext/src/System.Reflection.MetadataLoadContext.csproj | Changes EnableAOTAnalyzer=false to IsAotCompatible=false |
| src/libraries/System.Resources.Extensions/src/System.Resources.Extensions.csproj | Changes EnableAOTAnalyzer=false to IsAotCompatible=false |
| src/libraries/System.Runtime.InteropServices.JavaScript/src/System.Runtime.InteropServices.JavaScript.csproj | Changes EnableAOTAnalyzer=false to IsAotCompatible=false |
| src/libraries/System.Runtime.Serialization.Schema/src/System.Runtime.Serialization.Schema.csproj | Changes EnableAOTAnalyzer=false to IsAotCompatible=false |
| src/libraries/System.ServiceModel.Syndication/src/System.ServiceModel.Syndication.csproj | Changes EnableAOTAnalyzer=false to IsAotCompatible=false |
| src/libraries/System.Windows.Extensions/src/System.Windows.Extensions.csproj | Changes EnableAOTAnalyzer=false to IsAotCompatible=false |
pavelsavara
reviewed
Jul 29, 2025
...stem.Runtime.InteropServices.JavaScript/src/System.Runtime.InteropServices.JavaScript.csproj
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Jul 29, 2025
Member
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
Does this code path need to get updated?
Member
Author
No, the analyzer still should look for
edit: sorry, linked the wrong targets. They are actually built into the SDK: |
Member
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MichalStrehovsky
approved these changes
Jul 30, 2025
This was referenced Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of EnableAOTAnalyzer. This is necessary for the metadata added in #118008 to make it into our libraries.