Merged
Conversation
BrennanConroy
requested review from
PranavSenthilnathan,
Copilot and
eiriktsarpalis
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new fuzzer called Utf8JsonReaderFuzzer to the .NET runtime fuzzing infrastructure. The fuzzer is designed to comprehensively test JSON deserialization functionality by comparing behavior between span-based and sequence-based Utf8JsonReader instances.
Key changes:
- Implements a comprehensive JSON reader fuzzer that tests various data types and scenarios
- Adds pipeline configuration to deploy the fuzzer to OneFuzz testing infrastructure
- Includes testing for both primitive types and complex POCOs with dynamically generated types
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/libraries/Fuzzing/DotnetFuzzing/Fuzzers/Utf8JsonReaderFuzzer.cs |
Main fuzzer implementation with comprehensive JSON deserialization testing |
src/libraries/Fuzzing/DotnetFuzzing/DotnetFuzzing.csproj |
Project file updated to include the new fuzzer |
eng/pipelines/libraries/fuzzing/deploy-to-onefuzz.yml |
Pipeline configuration to deploy the fuzzer to OneFuzz |
src/libraries/Fuzzing/DotnetFuzzing/Fuzzers/Utf8JsonReaderFuzzer.cs
Outdated
Show resolved
Hide resolved
src/libraries/Fuzzing/DotnetFuzzing/Fuzzers/Utf8JsonReaderFuzzer.cs
Outdated
Show resolved
Hide resolved
src/libraries/Fuzzing/DotnetFuzzing/Fuzzers/Utf8JsonReaderFuzzer.cs
Outdated
Show resolved
Hide resolved
src/libraries/Fuzzing/DotnetFuzzing/Fuzzers/Utf8JsonReaderFuzzer.cs
Outdated
Show resolved
Hide resolved
src/libraries/Fuzzing/DotnetFuzzing/Fuzzers/Utf8JsonReaderFuzzer.cs
Outdated
Show resolved
Hide resolved
src/libraries/Fuzzing/DotnetFuzzing/Fuzzers/Utf8JsonReaderFuzzer.cs
Outdated
Show resolved
Hide resolved
- Replace Random seed with direct first-N-bytes control data so the fuzzing engine can see input-to-coverage relationship (MihaZupan) - Remove commented-out Debugger.Launch() (eiriktsarpalis) - Add double, long, Int128, char to ground types (eiriktsarpalis) - Construct random types recursively with List<>, Dictionary<,>, record, and POCO variants at maxDepth 1 (eiriktsarpalis) - Fix CompareExceptions(ex, ex) self-comparison bug - Fix incorrect comments (GetString, not DateTime) - Fix 'exponent exception' error message for same-key case Co-authored-by: Copilot <[email protected]>
BrennanConroy
force-pushed
the
brecon/fuzzjsondeserialize
branch
from
a099b20 to
a808151
Compare
eiriktsarpalis
approved these changes
Feb 25, 2026
Member
|
@MihuBot fuzz JsonReader -helix |
This was referenced Feb 25, 2026
|
Ran the fuzzer(s) successfully. Code coverage reports: |
This was referenced Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.