Permit ByRefLike types with ctor to be activated.
#117940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was an oversight from dotnet#102636. Added tests.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables Activator.CreateInstance<T>() to work with ByRefLike types (ref structs) that have constructors, which was previously blocked. The change allows generic activation of ref structs while maintaining the restriction that they cannot be boxed through non-generic activation methods.
Key changes:
- Modified the validation logic to permit ByRefLike types in generic activation scenarios
- Added comprehensive tests for ref struct activation with and without constructors
- Updated existing tests to reflect the new capability
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Private.CoreLib/src/System/Activator.RuntimeType.cs | Minor comment typo fix |
| src/libraries/System.Runtime/tests/System.Runtime.Tests/System/ActivatorTests.cs | Added test cases for ref struct activation and consolidated existing Span tests |
| src/coreclr/vm/runtimehandles.h | Removed unused function declaration |
| src/coreclr/vm/reflectioninvocation.cpp | Enhanced validation function to conditionally allow ByRefLike types |
| src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs | Added explicit ByRefLike checks in boxed activation paths |
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/ActivatorTests.cs
Show resolved
Hide resolved
jkotas
reviewed
Jul 22, 2025
src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jul 22, 2025
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/ActivatorTests.cs
Show resolved
Hide resolved
jkotas
reviewed
Jul 22, 2025
Open
3 tasks
Member
Author
|
/ba-g Known timeouts |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an oversight from #102636.
Added tests.
Fixes #117838