[release/10.0-preview7] Fix ILLink ref assembly build breaks#117916
Merged
ericstj merged 1 commit intorelease/10.0-preview7from Jul 22, 2025
Merged
[release/10.0-preview7] Fix ILLink ref assembly build breaks#117916ericstj merged 1 commit intorelease/10.0-preview7from
ericstj merged 1 commit intorelease/10.0-preview7from
Conversation
This is blocking dotnet/dotnet#1546. Looks like this got lost in all the WASM timeout noise in #117624. We can either suppress or add to ref assembly, but ref assembly only has things ILLink custom steps depend on. So suppression it is. I just regenerated it with `/p:ApiCompatGenerateSuppressionFile=true` so it shuffled two unrelated lines.
dotnet-policy-service
bot
added
the
linkable-framework
jeffhandley
approved these changes
Jul 22, 2025
MichalStrehovsky
approved these changes
Jul 22, 2025
This was referenced Jul 22, 2025
Open
Member
|
/ba-g timeout in wasm test build |
2 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #117875 to release/10.0-preview7
/cc @jeffhandley @MichalStrehovsky
Customer Impact
The Use compiler-lowered DAM when trimming (#117624) PR introduced a new build failure that was overlooked due to other noise of failing checks. This was reported in API compat error for
DisableGeneratedCodeHeuristicsin ILLink (#117854), which shows that all PRs into main were affected.Fix ILLink ref assembly build breaks (#117875) fixed the issue in main. Backporting that fix into Preview 7 will clean up the build state in the release branch while we stabilize the release.
Regression
It's not a product regression, but there was a regression in the build output, resulting in every PR having a check that fails.
Testing
Fix was merged into main, and subsequent PRs did not see the error.
Risk
Low. This addresses an API Compat validation failure that was missed in a previous PR.