Convert CoreCLR classic debug logging to use the minipal mutex#117689
Merged
jkoritzinsky merged 2 commits intodotnet:mainfrom Jul 16, 2025
Merged
Convert CoreCLR classic debug logging to use the minipal mutex#117689jkoritzinsky merged 2 commits intodotnet:mainfrom
jkoritzinsky merged 2 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @mangod9 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the CoreCLR Win32 PAL HANDLE–based logging mutex with the cross-platform minipal_mutex.
- Changed the global
LogFileMutextype fromHANDLEtominipal_mutex*. - Updated
EnterLogLock/LeaveLogLockto callminipal_mutex_enter/minipal_mutex_leave. - Modified
InitializeLoggingtonewand initialize aminipal_mutex, usingInterlockedCompareExchangeTto install it.
Comments suppressed due to low confidence (1)
src/coreclr/utilcode/log.cpp:184
- [nitpick] The local variable name 'mutex' is very generic and could be confused with the global 'LogFileMutex'. Consider renaming it to 'newLogFileMutex' or similar for clarity.
minipal_mutex* mutex = new minipal_mutex;
Co-authored-by: Aaron Robinson <[email protected]>
AaronRobinsonMSFT
approved these changes
Jul 16, 2025
Member
Author
|
/ba-g failures are unrelated |
This was referenced Jul 16, 2025
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes another usage of the CoreCLR Win32 PAL Mutex