[clr-interp] Add support for Vector64 and Vector128 return/argument types in interpreter stubs#117668
Merged
kotlarmilos merged 3 commits intodotnet:mainfrom Jul 16, 2025
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
kotlarmilos
commented
Jul 15, 2025
janvorli
approved these changes
Jul 15, 2025
Member
janvorli
left a comment
There was a problem hiding this comment.
LGTM modulo adding the #ifdef FEATURE_SIMD. Thank you!
This was referenced Jul 16, 2025
Open
Member
Author
|
/ba-g #117724 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for handling Vector64 and Vector128 values in interpreter stubs on arm64. It implements loading and returning of these types using SIMD registers
d0andq0according to the arm64 ABI.Changes
CallStubGenerator::GetReturnTypeto handle CORINFO_HFA_ELEM_VECTOR64 and CORINFO_HFA_ELEM_VECTOR128 as valid return types