Adding GetTLSIndex cDAC implementation#117587
Merged
rcj1 merged 4 commits intodotnet:mainfrom Jul 17, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Implements cDAC support for retrieving the TLS index on a target runtime.
- Added the GetTLSIndex method in
SOSDacImpl.cswith low-level reads, error handling, and debug assertions against the legacy DAC. - Introduced new constants
TlsIndexandTlsOutOfIndexesin the data contract for TLS globals. - Exposed
TLS_OUT_OF_INDEXESandg_TlsIndexindatadescriptor.hfor cDAC consumption.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.cs | Implements GetTLSIndex logic, argument validation, and debug checks |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Constants.cs | Adds TlsIndex and TlsOutOfIndexes to the Globals contract |
| src/coreclr/debug/runtimeinfo/datadescriptor.h | Declares CDAC globals for TlsOutOfIndexes and TlsIndex |
Comments suppressed due to low confidence (1)
src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.cs:1646
- Add unit tests for
GetTLSIndexcovering successful index retrieval, the S_FALSE case whenTlsIndex == TlsOutOfIndexes, and error paths to ensure the implementation behaves as expected.
int ISOSDacInterface.GetTLSIndex(uint* pIndex)
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
jkotas
reviewed
Jul 13, 2025
This was referenced Jul 16, 2025
Open
Contributor
Author
|
/ba-g android-x64 Release AllSubsets_CoreCLR timeout |
jkotas
reviewed
Jul 17, 2025
Member
|
LGTM otherwise |
This was referenced Jul 17, 2025
Contributor
Author
|
/ba-g baseservices-exceptions Work Item failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.