Protect against ODE when accessing configuration providers#117551
Merged
tarekgh merged 2 commits intodotnet:mainfrom Jul 12, 2025
Merged
Protect against ODE when accessing configuration providers#117551tarekgh merged 2 commits intodotnet:mainfrom
tarekgh merged 2 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds protection against ObjectDisposedException when iterating through configuration providers, ensuring disposed providers are skipped instead of propagating exceptions.
- Wraps the
provider.TryGetcall in a try/catch forObjectDisposedException - Adds explanatory comments for skipping disposed providers
Comments suppressed due to low confidence (2)
src/libraries/Microsoft.Extensions.Configuration/src/InternalConfigurationRootExtensions.cs:55
- Add a unit test that disposes a provider mid-enumeration to verify that
ObjectDisposedExceptionis correctly caught and the provider is skipped.
try
src/libraries/Microsoft.Extensions.Configuration/src/InternalConfigurationRootExtensions.cs:51
- Iterating directly over the
providerslist while it can be mutated byConfigurationManagermay lead to anInvalidOperationException. Consider capturing a snapshot (e.g.,var snapshot = providers.ToList()) before the loop to avoid collection modification issues.
for (int i = providers.Count - 1; i >= 0; i--)
halter73
approved these changes
Jul 11, 2025
halter73
reviewed
Jul 11, 2025
src/libraries/Microsoft.Extensions.Configuration/src/InternalConfigurationRootExtensions.cs
Outdated
Show resolved
Hide resolved
…onfigurationRootExtensions.cs Co-authored-by: Stephen Halter <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #117491