adding GetDomainFromContext cDAC API#117517
Merged
rcj1 merged 2 commits intodotnet:mainfrom Jul 11, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a managed implementation of GetDomainFromContext in SOSDacImpl with basic argument validation, assignment logic, and debug-only comparisons against the legacy DAC.
- Introduces a full-method body replacing the one-liner forward to
_legacyImpl - Validates inputs and sets the output pointer, capturing exceptions as HRESULTs
- Adds debug-only assertions to compare results with the legacy implementation
Comments suppressed due to low confidence (1)
src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.cs:247
- Add unit tests to cover the invalid-argument path (when
contextis zero ordomainis null) and the exception path to verify the correct HRESULT is returned.
if (context == 0 || domain == null)
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
max-charlamb
approved these changes
Jul 11, 2025
Member
max-charlamb
left a comment
max-charlamb
left a comment
There was a problem hiding this comment.
Looks good mod that one comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.