Report folded method bodies in the MSTAT file#117459
Merged
MichalStrehovsky merged 2 commits intodotnet:mainfrom Jul 18, 2025
Merged
Report folded method bodies in the MSTAT file#117459MichalStrehovsky merged 2 commits intodotnet:mainfrom
MichalStrehovsky merged 2 commits intodotnet:mainfrom
Conversation
So that we have this for statistics or visualizations when needed.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for reporting folded method bodies in the MSTAT output to improve downstream statistics and visualizations.
- Introduces a
GetNameAPI onIDependencyNodeand implements it in core framework types. - Adds a
ReportFoldedNodehook to the object-dumping infrastructure and invokes it in the object writer. - Enhances
MstatObjectDumperto collect, encode, and emit deduplicated method-body mappings.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework/IDependencyNode.cs | Added GetName method to the dependency-node interface |
| src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework/DependencyNodeCore.cs | Explicit interface implementation for the new GetName method |
| src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/ReachabilityInstrumentationProvider.cs | Provided a GetName implementation on UntrackedSymbol |
| src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/ObjectWriter/ObjectWriter.cs | Reports folded symbol nodes via ReportFoldedNode |
| src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/ObjectDumper.cs | Added default ReportFoldedNode in the dumper base class |
| src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/MstatObjectDumper.cs | Tracks and emits deduplicated method-body data |
| src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/IObjectDumper.cs | Declared new ReportFoldedNode in dumper interface |
Comments suppressed due to low confidence (4)
src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework/IDependencyNode.cs:44
- [nitpick] Consider adding an XML doc comment for the new
GetNamemethod to explain its purpose and expected return value.
string GetName(DependencyContextType context);
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/ObjectDumper.cs:19
- [nitpick] Add XML documentation to explain when and why
ReportFoldedNodeis called and how implementations should handle it.
public virtual void ReportFoldedNode(NodeFactory factory, ObjectNode originalNode, ISymbolNode targetNode) { }
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/IObjectDumper.cs:11
- [nitpick] Consider adding an XML doc comment to the interface method to describe its contract and potential side effects.
void ReportFoldedNode(NodeFactory factory, ObjectNode originalNode, ISymbolNode targetNode);
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/MstatObjectDumper.cs:183
- New logic for collecting and encoding deduplicated method bodies should be covered by a unit or integration test to verify the MSTAT output includes the expected
DeduplicatedMethodssection.
var deduplicatedMethods = new InstructionEncoder(new BlobBuilder());
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/ReachabilityInstrumentationProvider.cs
Outdated
Show resolved
Hide resolved
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
…yInstrumentationProvider.cs Co-authored-by: Copilot <[email protected]>
This was referenced Jul 9, 2025
Member
Author
|
@sbomer is this something you'd be comfortable reviewing? |
sbomer
approved these changes
Jul 17, 2025
Member
Author
|
/ba-g wasm deadletters |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that we have this for statistics or visualizations when needed.
Cc @dotnet/ilc-contrib