Make test projects that reference NativeExports platform-specific#117383
Merged
jtschuster merged 2 commits intodotnet:mainfrom Jul 8, 2025
Merged
Make test projects that reference NativeExports platform-specific#117383jtschuster merged 2 commits intodotnet:mainfrom
jtschuster merged 2 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates test projects that reference NativeExports to be platform-specific by including the runtime identifier in their output paths, enabling side-by-side builds for multiple architectures.
- Adds
<RuntimeIdentifier>$(TargetRid)</RuntimeIdentifier>to relevant test project files - Documents the platform-specific nature of NativeExports in a comment
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/LibraryImportGenerator.Tests.csproj | Adds RuntimeIdentifier and comment for NativeExports dependency |
| src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Tests/ComInterfaceGenerator.Tests.csproj | Adds RuntimeIdentifier and comment for NativeExports dependency |
jkoritzinsky
approved these changes
Jul 7, 2025
Member
jkoritzinsky
left a comment
jkoritzinsky
left a comment
There was a problem hiding this comment.
If the tests still run on Helix, LGTM!
This was referenced Jul 8, 2025
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now they will have the RID in the output path and multiple architectures can be build side by side.
Closes #96572