Skip to content

Fix Infinite loop on OdbcDataReader.internalGetString with UTF-8 text#117192

Closed
MohamedChaawa wants to merge 15 commits intodotnet:mainfrom
MohamedChaawa:patch-1
Closed

Fix Infinite loop on OdbcDataReader.internalGetString with UTF-8 text#117192
MohamedChaawa wants to merge 15 commits intodotnet:mainfrom
MohamedChaawa:patch-1

Conversation

@MohamedChaawa
Copy link

@MohamedChaawa MohamedChaawa commented Jul 1, 2025

Fix Infinite loop on OdbcDataReader.internalGetString with UTF-8 text.

When the lengthOrIndicator is 0 the loop should be broken.
This change fixes the issue #86490

@MohamedChaawa
Fix Infinite loop on OdbcDataReader.internalGetString with UTF-8 text
cbe9ab5 
Fix Infinite loop on OdbcDataReader.internalGetString with UTF-8 text.

When the lengthOrIndicator is 0 the loop should be broken.
This change fixes the issue dotnet#86490
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 1, 2025
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 1, 2025
@build-analysis build-analysis bot mentioned this pull request Jul 1, 2025
Open
@MohamedChaawa MohamedChaawa requested a review from stephentoub July 1, 2025 14:28
This was referenced Jul 1, 2025
Closed
Open
@stephentoub
Copy link
Member

stephentoub commented Jul 1, 2025

Is it possible to add a test for this?

This was referenced Jul 2, 2025
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Jul 10, 2025
Closed
@MohamedChaawa
Copy link
Author

MohamedChaawa commented Jul 10, 2025

@dotnet-policy-service agree

@MohamedChaawa
Copy link
Author

MohamedChaawa commented Jul 10, 2025

Is it possible to add a test for this?

@stephentoub OdbcDataReaderTests is added.

@build-analysis build-analysis bot mentioned this pull request Jul 11, 2025
Closed
3 tasks
stephentoub
stephentoub reviewed Jul 11, 2025
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Jul 12, 2025
Open
3 tasks
@build-analysis build-analysis bot mentioned this pull request Jul 12, 2025
Closed
@build-analysis build-analysis bot mentioned this pull request Jul 12, 2025
Closed
@stephentoub
Copy link
Member

stephentoub commented Jul 15, 2025

Thanks.

I pulled down your change and tried running the test without the fix, and it still passes.

Is this test validating what you expect it to validate?

@stephentoub stephentoub added needs-author-action An issue or pull request that requires more info or actions from the author. area-System.Data area-System.Data.Odbc and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners area-System.Data labels Jul 18, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Jul 18, 2025

Tagging subscribers to this area: @roji, @SamMonoRT
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Aug 1, 2025

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Aug 15, 2025

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub left review comments

Assignees

No one assigned

Labels

area-System.Data.Odbc community-contribution Indicates that the PR has been added by a community member needs-author-action An issue or pull request that requires more info or actions from the author. no-recent-activity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MohamedChaawa @stephentoub