JIT: Allow compaction of blocks with switch predecessors#117177
Merged
amanasifkhalid merged 1 commit intodotnet:mainfrom Jul 1, 2025
Merged
JIT: Allow compaction of blocks with switch predecessors#117177amanasifkhalid merged 1 commit intodotnet:mainfrom
amanasifkhalid merged 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the JIT by allowing compaction of blocks even if they have switch predecessors, taking advantage of trivial switch successor edge redirection.
- Removed the check that prevented block compaction when a switch predecessor was present.
- Simplified the logic in fgCanCompactBlock() to always return true when no blocking conditions besides the removed check exist.
Comments suppressed due to low confidence (1)
src/coreclr/jit/fgopt.cpp:838
- Update the function's comment to reflect that compaction is now allowed for blocks with switch predecessors, ensuring that future maintainers understand this behavioral change.
return false;
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced Jun 30, 2025
Contributor
Author
|
cc @dotnet/jit-contrib, @AndyAyersMS PTAL. Small diffs. Thanks! |
AndyAyersMS
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that switch successor edge redirection is trivial, we can compact blocks with switch predecessors without worrying about invalidating the entire switch successor map.