Include Pkcs (net10.0 & -windows) in aspnetcore transport pack#117173
Merged
ViktorHofer merged 1 commit intomainfrom Jul 1, 2025
Merged
Include Pkcs (net10.0 & -windows) in aspnetcore transport pack#117173ViktorHofer merged 1 commit intomainfrom
ViktorHofer merged 1 commit intomainfrom
Conversation
github-actions
bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures the System.Security.Cryptography.Pkcs assembly for the net10.0-windows TFM is included in the ASP.NET Core transport pack.
- Adds
System.Security.Cryptography.Pkcsto the shared framework props so it’s available in .NET 10. - References the Pkcs project with a windows-specific TFM and wires it into the transport pack MSBuild logic.
- Adjusts path separators in
packaging.targetsto flatten package and symbol output paths.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/NetCoreAppLibrary.props | Added System.Security.Cryptography.Pkcs to the list of included shared framework assemblies |
| src/libraries/Microsoft.Internal.Runtime.AspNetCore.Transport/src/Microsoft.Internal.Runtime.AspNetCore.Transport.proj | Added a windows-targeted Pkcs ProjectReference and a custom target to surface it |
| eng/packaging.targets | Switched to forward slashes and removed redundant separators in package/symbol paths |
Comments suppressed due to low confidence (3)
src/libraries/Microsoft.Internal.Runtime.AspNetCore.Transport/src/Microsoft.Internal.Runtime.AspNetCore.Transport.proj:40
- Consider adding an integration or packaging test to verify that the Pkcs DLL and its PDB actually end up in the
runtimes/win/lib/$(NetCoreAppCurrent)folder of the generated ASP.NET Core transport package.
<ProjectReference Include="$(LibrariesProjectRoot)System.Security.Cryptography.Pkcs\src\System.Security.Cryptography.Pkcs.csproj"
eng/packaging.targets:253
- Mixing forward slashes and backslashes in MSBuild paths can lead to inconsistent output on Windows. Consider using
$(BuildOutputTargetFolder)\$(_referringTargetFramework)\or normalizing separators uniformly.
PackagePath="$([MSBuild]::ValueOrDefault('%(ReferenceCopyLocalPaths.PackagePath)', '$(BuildOutputTargetFolder)/$(_referringTargetFramework)/'))" />
eng/packaging.targets:255
- This relies on
PackagePathending with a slash. If it doesn't, output paths may run together. You might add a slash in the metadata or useTrimEnd('\/')and then append a single separator.
TargetPath="/%(TfmSpecificPackageFile.PackagePath)%(Filename)%(Extension)"
This was referenced Jun 30, 2025
Member
Author
|
/ba-g failures are unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #117146