Remove CmsSigner.HasPrivateKey#117113
Merged
PranavSenthilnathan merged 1 commit intodotnet:mainfrom Jun 28, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the obsolete HasPrivateKey property from CmsSigner, deletes its public API surface, and removes the accompanying tests.
- Remove
HasPrivateKeyfromCmsSigner.csand reference assembly - Drop tests in
CmsSignerTests.csthat referencedHasPrivateKey - Update ref assembly
System.Security.Cryptography.Pkcs.netcoreapp.csto no longer exposeHasPrivateKey
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/System.Security.Cryptography.Pkcs/tests/SignedCms/CmsSignerTests.cs | Removed tests for HasPrivateKey |
| src/libraries/System.Security.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/CmsSigner.cs | Deleted the HasPrivateKey property declaration |
| src/libraries/System.Security.Cryptography.Pkcs/ref/System.Security.Cryptography.Pkcs.netcoreapp.cs | Removed HasPrivateKey from public ref API |
Comments suppressed due to low confidence (2)
src/libraries/System.Security.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/CmsSigner.cs:34
- If you have public XML docs or markdown that mention
HasPrivateKey, update them to reflect the removal and direct consumers to usePrivateKeynullity checks instead.
set => _privateKey = value;
src/libraries/System.Security.Cryptography.Pkcs/tests/SignedCms/CmsSignerTests.cs:49
- [nitpick] Consider adding tests for scenarios where
PrivateKeyis null or set to ensure the replacement null-check behavior works as expected now thatHasPrivateKeyis gone.
[Fact]
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
This was referenced Jun 28, 2025
bartonjs
approved these changes
Jun 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #116282