Use defined width types in PatchpointInfo#117029
Merged
max-charlamb merged 4 commits intodotnet:mainfrom Jun 27, 2025
Merged
Conversation
github-actions
bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces platform-dependent unsigned/int types in PatchpointInfo with explicit-width types (uint32_t/int32_t) to make sizes clear for marshalling DebugInfo.
- Changed all method parameters, return types, and member fields to fixed-width types.
- Updated
ComputeSizeand related calculations to useuint32_t. - Adjusted comments accordingly.
Comments suppressed due to low confidence (1)
src/coreclr/inc/patchpointinfo.h:66
- The comment refers to
patchpoint32_tby mistake; it should sayPatchpointInfoto match the struct name.
// Total size of this patchpoint32_t info record, in bytes
max-charlamb
removed
the
needs-area-label
Contributor
|
Tagging subscribers to this area: @mangod9 |
Co-authored-by: Copilot <[email protected]>
AndyAyersMS
approved these changes
Jun 26, 2025
jakobbotsch
reviewed
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cDAC needs to read
PatchpointInfo::m_numberOfLocalsto properly parse method'sDebugInfo. As part of this marshalling, we need to know the width of the type.While I'm pretty sure
unsigned <var>will always be 32bits on our target platforms, using the defined width types makes this explicit. I think this is a simple change unless there are objections.