Add missing CultureInfo.InvariantCulture use to LogValuesFormatter#117008
Merged
stephentoub merged 2 commits intodotnet:mainfrom Jun 27, 2025
Merged
Add missing CultureInfo.InvariantCulture use to LogValuesFormatter#117008stephentoub merged 2 commits intodotnet:mainfrom
stephentoub merged 2 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-extensions-logging |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that LogValuesFormatter uses CultureInfo.InvariantCulture when formatting values and adds a corresponding test to validate culture-invariant output.
LogValuesFormatterformatting methods now explicitly passCultureInfo.InvariantCulturefor placeholder indices and enumerable elements.- A new unit test
FormatMessage_UsesInvariantCulturehas been added toLoggerExtensionsTest.csto verify behavior under a non-default culture. - Imported
System.Globalizationwhere needed.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/Microsoft.Extensions.Logging.Abstractions/src/LogValuesFormatter.cs | Use CultureInfo.InvariantCulture in ToString calls for consistent output |
| src/libraries/Microsoft.Extensions.Logging/tests/Common/LoggerExtensionsTest.cs | Added test FormatMessage_UsesInvariantCulture and imported System.Globalization |
Comments suppressed due to low confidence (1)
src/libraries/Microsoft.Extensions.Logging.Abstractions/src/LogValuesFormatter.cs:69
- Ensure the
System.Globalizationnamespace is imported at the top of this file so thatCultureInfo.InvariantCultureresolves correctly and the code compiles without errors.
vsb.Append(_valueNames.Count.ToString(CultureInfo.InvariantCulture));
This was referenced Jun 25, 2025
tarekgh
reviewed
Jun 25, 2025
src/libraries/Microsoft.Extensions.Logging/tests/Common/LoggerExtensionsTest.cs
Outdated
Show resolved
Hide resolved
This was referenced Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #116979