[RISC-V] Substituting INS_ori and INS_addi with INS_mov for zero immediate values by namu-lee · Pull Request #116956 · dotnet/runtime

namu-lee · 2025-06-24T10:30:17Z

Substituting INS_ori and INS_addi with INS_mov for zero immediate values.

@clamp03 @tomeksowi @SkyShield, @credo-quia-absurdum
part of #84834, cc @dotnet/samsung

Copilot

Pull Request Overview

This PR substitutes 32-bit addi/ori instructions with the 16-bit compressed mv (INS_mov) for zero immediates in RISC-V codegen, reducing native code size.

genSimpleReturn now emits INS_mov instead of INS_addi when the immediate is zero.
Several local-heap, cast, and LEA emitters replace emitIns_R_R_I(..., 0) with emitIns_R_R(INS_mov, ...).

Comments suppressed due to low confidence (1)

src/coreclr/jit/codegenriscv64.cpp:1429

There are no unit tests verifying that INS_mov is emitted for zero immediates; consider adding codegen tests to ensure mv is generated instead of addi/ori and that code size benefits are validated.

                emit->emitIns_R_R(INS_mov, easz, regCnt, targetReg);

src/coreclr/jit/codegenriscv64.cpp

dotnet-policy-service · 2025-06-24T10:31:13Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

risc-vv · 2025-06-24T10:36:13Z

RISC-V Release-CLR-QEMU: 9086 / 9116 (99.67%)

=======================
      passed: 9086
      failed: 2
     skipped: 600
      killed: 28
------------------------
 TOTAL tests: 9716
VIRTUAL time: 35h 8min 38s 406ms
   REAL time: 36min 0s 243ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-CLR-VF2: 9087 / 9117 (99.67%)

=======================
      passed: 9087
      failed: 2
     skipped: 600
      killed: 28
------------------------
 TOTAL tests: 9717
VIRTUAL time: 11h 21min 24s 799ms
   REAL time: 46min 2s 681ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-FX-QEMU: 283841 / 284911 (99.62%)

=======================
      passed: 283841
      failed: 1065
     skipped: 39
      killed: 5
------------------------
 TOTAL tests: 284950
VIRTUAL time: 30h 6min 12s 171ms
   REAL time: 1h 11min 50s 776ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-FX-VF2: 510321 / 512066 (99.66%)

=======================
      passed: 510321
      failed: 1736
     skipped: 39
      killed: 9
------------------------
 TOTAL tests: 512105
VIRTUAL time: 24h 39min 53s 929ms
   REAL time: 2h 12min 1s 730ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 735cdcdbab5e439c25eb9b462770cf6b2c4cc28f
CI: 01a69d638efe9b8b18c2888449be98b4a6cde211
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

clamp03 · 2025-06-25T06:50:05Z

cc @tomeksowi

src/coreclr/jit/codegenriscv64.cpp

risc-vv · 2025-06-25T09:11:03Z

RISC-V Release-CLR-QEMU: 9086 / 9116 (99.67%)

=======================
      passed: 9086
      failed: 2
     skipped: 600
      killed: 28
------------------------
 TOTAL tests: 9716
VIRTUAL time: 35h 19min 1s 392ms
   REAL time: 36min 11s 28ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-CLR-VF2: 9087 / 9117 (99.67%)

=======================
      passed: 9087
      failed: 2
     skipped: 600
      killed: 28
------------------------
 TOTAL tests: 9717
VIRTUAL time: 11h 41min 58s 804ms
   REAL time: 47min 12s 22ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-FX-QEMU: 275972 / 277043 (99.61%)

=======================
      passed: 275972
      failed: 1065
     skipped: 39
      killed: 6
------------------------
 TOTAL tests: 277082
VIRTUAL time: 30h 14min 46s 188ms
   REAL time: 1h 11min 9s 687ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-FX-VF2: 498288 / 500030 (99.65%)

=======================
      passed: 498288
      failed: 1733
     skipped: 39
      killed: 9
------------------------
 TOTAL tests: 500069
VIRTUAL time: 22h 54min 33s 821ms
   REAL time: 2h 17min 32s 80ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 0ac9ad8c7316303a6eba621cbdf48a6deca7d398
CI: 01a69d638efe9b8b18c2888449be98b4a6cde211
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

risc-vv · 2025-06-25T10:21:12Z

RISC-V Release-CLR-VF2: 9087 / 9117 (99.67%)

=======================
      passed: 9087
      failed: 2
     skipped: 600
      killed: 28
------------------------
 TOTAL tests: 9717
VIRTUAL time: 11h 28min 58s 156ms
   REAL time: 46min 30s 246ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 10a76f3964bf8ed73db3edc7fa0e426afc5c8293
CI: 01a69d638efe9b8b18c2888449be98b4a6cde211
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

risc-vv · 2025-06-25T10:46:14Z

RISC-V Release-FX-QEMU: 283642 / 284660 (99.64%)

=======================
      passed: 283642
      failed: 1011
     skipped: 39
      killed: 7
------------------------
 TOTAL tests: 284699
VIRTUAL time: 29h 31min 29s 467ms
   REAL time: 1h 10min 50s 64ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 10a76f3964bf8ed73db3edc7fa0e426afc5c8293
CI: 01a69d638efe9b8b18c2888449be98b4a6cde211
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

risc-vv · 2025-06-25T11:21:10Z

RISC-V Release-CLR-QEMU: 9086 / 9116 (99.67%)

=======================
      passed: 9086
      failed: 2
     skipped: 600
      killed: 28
------------------------
 TOTAL tests: 9716
VIRTUAL time: 35h 16min 2s 426ms
   REAL time: 36min 7s 55ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 10a76f3964bf8ed73db3edc7fa0e426afc5c8293
CI: 01a69d638efe9b8b18c2888449be98b4a6cde211
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

risc-vv · 2025-06-25T11:56:08Z

RISC-V Release-FX-QEMU: 283846 / 284916 (99.62%)

=======================
      passed: 283846
      failed: 1063
     skipped: 39
      killed: 7
------------------------
 TOTAL tests: 284955
VIRTUAL time: 31h 17min 41s 328ms
   REAL time: 1h 11min 1s 293ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-CLR-QEMU: 9086 / 9116 (99.67%)

=======================
      passed: 9086
      failed: 2
     skipped: 600
      killed: 28
------------------------
 TOTAL tests: 9716
VIRTUAL time: 35h 26min 51s 814ms
   REAL time: 36min 17s 724ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-FX-VF2: 305373 / 307123 (99.43%)

=======================
      passed: 305373
      failed: 1740
     skipped: 39
      killed: 10
------------------------
 TOTAL tests: 307162
VIRTUAL time: 21h 36min 28s 964ms
   REAL time: 2h 15min 27s 693ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 10a76f3964bf8ed73db3edc7fa0e426afc5c8293
CI: 01a69d638efe9b8b18c2888449be98b4a6cde211
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

risc-vv · 2025-06-25T14:01:14Z

RISC-V Release-CLR-VF2: 9087 / 9117 (99.67%)

=======================
      passed: 9087
      failed: 2
     skipped: 600
      killed: 28
------------------------
 TOTAL tests: 9717
VIRTUAL time: 10h 26min 20s 249ms
   REAL time: 42min 30s 116ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-FX-QEMU: 281186 / 282272 (99.62%)

=======================
      passed: 281186
      failed: 1080
     skipped: 39
      killed: 6
------------------------
 TOTAL tests: 282311
VIRTUAL time: 30h 47min 53s 45ms
   REAL time: 1h 11min 52s 374ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-CLR-QEMU: 9086 / 9116 (99.67%)

=======================
      passed: 9086
      failed: 2
     skipped: 600
      killed: 28
------------------------
 TOTAL tests: 9716
VIRTUAL time: 35h 30min 18s 785ms
   REAL time: 36min 22s 203ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 10a76f3964bf8ed73db3edc7fa0e426afc5c8293
CI: 01a69d638efe9b8b18c2888449be98b4a6cde211
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

clamp03 · 2025-06-26T01:38:24Z

@jakobbotsch @jkotas Could you review and merge this PR? This is substituting instructions with RISC-V pseudo instructions for better code readability. Thank you.

risc-vv · 2025-06-26T10:50:55Z

RISC-V Release-CLR-QEMU: 9086 / 9116 (99.67%)

=======================
      passed: 9086
      failed: 2
     skipped: 600
      killed: 28
------------------------
 TOTAL tests: 9716
VIRTUAL time: 35h 13min 6s 612ms
   REAL time: 36min 3s 115ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-CLR-VF2: 9087 / 9117 (99.67%)

=======================
      passed: 9087
      failed: 2
     skipped: 600
      killed: 28
------------------------
 TOTAL tests: 9717
VIRTUAL time: 10h 46min 20s 897ms
   REAL time: 43min 44s 198ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-FX-QEMU: 283473 / 284549 (99.62%)

=======================
      passed: 283473
      failed: 1069
     skipped: 39
      killed: 7
------------------------
 TOTAL tests: 284588
VIRTUAL time: 31h 6min 52s 670ms
   REAL time: 1h 11min 43s 192ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-FX-VF2: 308390 / 310083 (99.45%)

=======================
      passed: 308390
      failed: 1682
     skipped: 39
      killed: 11
------------------------
 TOTAL tests: 310122
VIRTUAL time: 21h 37min 34s 550ms
   REAL time: 2h 9min 31s 659ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 92cc1f551a0169497ae0a7da9b9f29189caad99d
CI: 01a69d638efe9b8b18c2888449be98b4a6cde211
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

clamp03 · 2025-06-30T01:11:59Z

@jakobbotsch Could you merge if there is no problem in this PR?

jakobbotsch · 2025-06-30T11:33:46Z

/ba-g Unrelated failures

namu-lee added 2 commits June 24, 2025 19:01

[RISC-V] Replace INS_ori with INS_mov when immediate is 0

d536d3c

[RISC-V] Replace INS_addi with INS_mov when immediate is 0

735cdcd

Copilot AI review requested due to automatic review settings June 24, 2025 10:30

github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 24, 2025

dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 24, 2025

Copilot AI reviewed Jun 24, 2025

View reviewed changes

src/coreclr/jit/codegenriscv64.cpp Outdated Show resolved Hide resolved

clamp03 added the arch-riscv Related to the RISC-V architecture label Jun 25, 2025

clamp03 assigned namu-lee Jun 25, 2025

clamp03 approved these changes Jun 25, 2025

View reviewed changes

tomeksowi approved these changes Jun 25, 2025

View reviewed changes

tomeksowi reviewed Jun 25, 2025

View reviewed changes

src/coreclr/jit/codegenriscv64.cpp Outdated Show resolved Hide resolved

tomeksowi reviewed Jun 25, 2025

View reviewed changes

src/coreclr/jit/codegenriscv64.cpp Show resolved Hide resolved

namu-lee added 2 commits June 25, 2025 18:46

Improve code style

fae8f21

Substitute INS_slliw with INS_sext_w when immediate is 0

10a76f3

namu-lee force-pushed the instruction-compression branch from 0ac9ad8 to 10a76f3 Compare June 25, 2025 10:18

build-analysis bot mentioned this pull request Jun 25, 2025

browser-wasm Windows build error #116746

Closed

jakobbotsch approved these changes Jun 26, 2025

View reviewed changes

Merge branch 'main' into instruction-compression

92cc1f5

build-analysis bot mentioned this pull request Jun 26, 2025

Assertion failed 'm_dfsTree->Contains(dominator) && m_dfsTree->Contains(dominated)' #117039

Closed

jakobbotsch merged commit da3d9d0 into dotnet:main Jun 30, 2025
108 of 112 checks passed

namu-lee deleted the instruction-compression branch June 30, 2025 11:34

github-actions bot locked and limited conversation to collaborators Jul 31, 2025

namu-lee restored the instruction-compression branch January 28, 2026 08:47

Conversation

namu-lee commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

dotnet-policy-service bot commented Jun 24, 2025

Uh oh!

risc-vv commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clamp03 commented Jun 25, 2025

Uh oh!

Uh oh!

Uh oh!

risc-vv commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

risc-vv commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

risc-vv commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

risc-vv commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

risc-vv commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

risc-vv commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clamp03 commented Jun 26, 2025

Uh oh!

risc-vv commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clamp03 commented Jun 30, 2025

Uh oh!

jakobbotsch commented Jun 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

namu-lee commented Jun 24, 2025 •

edited

Loading

risc-vv commented Jun 24, 2025 •

edited

Loading

risc-vv commented Jun 25, 2025 •

edited

Loading

risc-vv commented Jun 25, 2025 •

edited

Loading

risc-vv commented Jun 25, 2025 •

edited

Loading

risc-vv commented Jun 25, 2025 •

edited

Loading

risc-vv commented Jun 25, 2025 •

edited

Loading

risc-vv commented Jun 25, 2025 •

edited

Loading

risc-vv commented Jun 26, 2025 •

edited

Loading