Ignore revocation checking failures on HTTPS tests on OSX#116910
Ignore revocation checking failures on HTTPS tests on OSX#116910rzikm merged 4 commits intodotnet:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances logging for certificate validation errors in the HttpClientHandler tests by outputting detailed information about each certificate in the chain along with associated error statuses.
- Added a loop to iterate through all certificate chain elements and output certificate details and status information.
- Logged overall SSL policy errors at the end of the callback.
github-actions
bot
added
the
needs-area-label
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries-coreclr outerloop-osx |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rzikm
changed the title
rzikm
added
area-System.Net.Http
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/ncl |
|
are we forcing customers to basically do the same? |
for customers, the right way to fix this would be disabling certificate revocation checking, but it is true that this might start affecting more people than we originally expected. I am wondering if we should consider different default for OSX. |
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.ServerCertificates.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.ServerCertificates.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.ServerCertificates.cs
Outdated
Show resolved
Hide resolved
|
I added a mention about ignoring revocation status unknown status when building the chain to the breaking change doc. |
This PR applies similar fix as in #22644 to Outerloop HTTPS tests where we check exact certificate validation errors. Additional context is also available at #25872