Sve2 AddHighNarrowing (Even/Odd)#116848
Merged
amanasifkhalid merged 6 commits intodotnet:mainfrom Jun 30, 2025
Merged
Conversation
dotnet-policy-service
bot
added
the
community-contribution
This was referenced Jun 20, 2025
jacob-crawley
force-pushed
the
sve2-add-high
branch
2 times, most recently
from
32faa1e to
9a5f186
Compare
src/tests/JIT/HardwareIntrinsics/Arm/Shared/_SveBinaryOpDifferentRetTypeTestTemplate.template
Outdated
Show resolved
Hide resolved
src/tests/JIT/HardwareIntrinsics/Arm/Shared/_SveBinaryOpDifferentRetTypeTestTemplate.template
Show resolved
Hide resolved
kunalspathak
suggested changes
Jun 20, 2025
Contributor
kunalspathak
left a comment
kunalspathak
left a comment
There was a problem hiding this comment.
added some comments around test.
jacob-crawley
force-pushed
the
sve2-add-high
branch
from
9a5f186 to
949e5bd
Compare
jacob-crawley
force-pushed
the
sve2-add-high
branch
from
949e5bd to
14f6718
Compare
jacob-crawley
force-pushed
the
sve2-add-high
branch
2 times, most recently
from
e59c2c1 to
7366cb4
Compare
a74nh
reviewed
Jun 30, 2025
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve2.cs
Outdated
Show resolved
Hide resolved
Contributor
|
@dotnet/arm64-contrib @amanasifkhalid |
auto-merge was automatically disabled
June 30, 2025 12:54
Head branch was pushed to by a user without write access
jacob-crawley
force-pushed
the
sve2-add-high
branch
from
7366cb4 to
5251f8f
Compare
jacob-crawley
changed the title
amanasifkhalid
approved these changes
Jun 30, 2025
Contributor
amanasifkhalid
left a comment
amanasifkhalid
left a comment
There was a problem hiding this comment.
LGTM too, thanks for the test cleanup
Contributor
|
/ba-g hit #111922 on x64 config |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@a74nh @kunalspathak
Contributing towards #115479