Skip to content

Use set on Windows, not export#116745

Merged
ilonatommy merged 8 commits intodotnet:mainfrom
ilonatommy:fix-xunit-diagnostics
Nov 25, 2025
Merged

Use set on Windows, not export#116745
ilonatommy merged 8 commits intodotnet:mainfrom
ilonatommy:fix-xunit-diagnostics

Conversation

@ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Jun 17, 2025

Found in library logs: #116695 (comment).

'export' is not recognized as an internal or external command

log

TargetOS is browser and command form should not depend on it. The change removes the error from logs.

@ilonatommy ilonatommy requested review from akoeplinger and maraf June 17, 2025 14:58
@ilonatommy ilonatommy self-assigned this Jun 17, 2025
Copilot AI review requested due to automatic review settings June 17, 2025 14:58
@ilonatommy ilonatommy added the arch-wasm WebAssembly architecture label Jun 17, 2025
@ilonatommy ilonatommy changed the title Use set on Windows, not `export' Use set on Windows, not export Jun 17, 2025
Copilot AI reviewed Jun 17, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses an issue from runtime logs by correcting the command used for setting environment variables on Windows.

  • Replace condition from using "$(TargetOS)" to using "$(OS)" for proper Windows detection.
  • Update both Windows and non-Windows branches to ensure the appropriate command ("set" for Windows, "export" for others) is used.
Comments suppressed due to low confidence (2)

eng/testing/xunit/xunit.console.targets:16

  • Ensure that the $(OS) variable is consistently set in all expected environments; if there is any risk it might be missing in some CI configurations, consider adding a fallback or additional documentation.
    <SetScriptCommands Condition="'$(OS)' == 'Windows_NT'" Include="set XUNIT_HIDE_PASSING_OUTPUT_DIAGNOSTICS=1" />

eng/testing/xunit/xunit.console.targets:17

  • Verify that using the $(OS) condition for non-Windows environments reliably covers all target platforms, and document any assumptions if necessary.
    <SetScriptCommands Condition="'$(OS)' != 'Windows_NT'" Include="export XUNIT_HIDE_PASSING_OUTPUT_DIAGNOSTICS=1" />

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 17, 2025
@lewing
Copy link
Member

lewing commented Jun 17, 2025 •
edited
Loading

This keeps getting flipped back and forth https://github.com/dotnet/runtime/pull/107349/files

This was referenced Jun 17, 2025
Open
Closed
Open
@ilonatommy
Copy link
Member Author

ilonatommy commented Jun 18, 2025 •
edited
Loading

This keeps getting flipped back and forth https://github.com/dotnet/runtime/pull/107349/files

We can wait for @pavelsavara but looking in the binlog, the check for TargetOS does not make sense.

javascript.interop.tests.binlog.zip

image

image

image

@ilonatommy ilonatommy requested a review from pavelsavara June 18, 2025 07:37
maraf
maraf reviewed Jun 18, 2025
View reviewed changes
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have non trivial amount placed where we set envvars like this. We have to always duplicate the lines. Could we do better?

@maraf
Copy link
Member

maraf commented Jun 18, 2025

This keeps getting flipped back and forth https://github.com/dotnet/runtime/pull/107349/files

Wasm.Build.Tests use OS as well

@ilonatommy
Copy link
Member Author

ilonatommy commented Jun 18, 2025 •
edited
Loading

We have non trivial amount placed where we set envvars like this. We have to always duplicate the lines. Could we do better?

For this particular case (envvar setting) we could have

<PropertyGroup>
  <EnvVarCommand Condition="'$(OS)' == 'Windows_NT'">set</EnvVarCommand>
  <EnvVarCommand Condition="'$(OS)' != 'Windows_NT'">export</EnvVarCommand>
</PropertyGroup>

<ItemGroup>
  <SetScriptCommands Include="$(EnvVarCommand) XUNIT_HIDE_PASSING_OUTPUT_DIAGNOSTICS=1" />
</ItemGroup>

not yet sure where to set the 1st part, to be early enough for all the test cases.

Edit:
we also are checking for Condition="'$(TargetsWindows)' == 'true' or '$(TargetPlatformIdentifier)' == 'windows'"

runtime/eng/testing/tests.props

Line 30 in 3c5f74a

<RunScriptCommands Condition="'$(TargetsWindows)' == 'true' or '$(TargetPlatformIdentifier)' == 'windows'" Include="set MONO_ENV_OPTIONS='$(MonoEnvOptions)'" />

for WindowsShell in helix-related actions and for TestWrapperTargetsWindows in helix&arcade.

@build-analysis build-analysis bot mentioned this pull request Jun 18, 2025
Closed
3 tasks
@ilonatommy ilonatommy mentioned this pull request Jun 18, 2025
Closed
This was referenced Jun 18, 2025
Closed
Open
Closed
This was referenced Jun 23, 2025
Open
Closed
@teo-tsirpanis teo-tsirpanis added area-Infrastructure-mono and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 28, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Jun 28, 2025

Tagging subscribers to this area: @akoeplinger, @matouskozak, @simonrozsival
See info in area-owners.md if you want to be subscribed.

@pavelsavara
Copy link
Member

pavelsavara commented Jun 30, 2025

This keeps getting flipped back and forth https://github.com/dotnet/runtime/pull/107349/files

We can wait for @pavelsavara but looking in the binlog, the check for TargetOS does not make sense.

I don't claim I understand any of that.

@ilonatommy
Copy link
Member Author

ilonatommy commented Jun 30, 2025

this is blocked by library failures

@ilonatommy ilonatommy added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jun 30, 2025
@build-analysis build-analysis bot mentioned this pull request Jun 30, 2025
Open
@ilonatommy ilonatommy removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Nov 24, 2025
@ilonatommy
Copy link
Member Author

ilonatommy commented Nov 24, 2025 •
edited
Loading

@maraf, continuing our offline discussion, the optimization was mostly done, I added it in a few more places where WindowsShell controls the flow and eliminated set/export duplicated lines. I left the duplicates where it comes to path encoding differences, MSBuild does not have an inbuilt tool for that.

EnvVarCommand is defined only in sendtohelix-wasm.targets because wasi and browser targets import it.

@build-analysis build-analysis bot mentioned this pull request Nov 24, 2025
Closed
@ilonatommy
Copy link
Member Author

ilonatommy commented Nov 24, 2025

Something interesting happened to the build. It did finish:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=1211200&view=ms.vss-test-web.build-test-results-tab
image

@ilonatommy ilonatommy requested a review from maraf November 24, 2025 15:43
This was referenced Nov 24, 2025
Open
Open
Open
Open
Open
@ilonatommy ilonatommy enabled auto-merge (squash) November 25, 2025 07:35
@ilonatommy ilonatommy merged commit 5eca9d9 into dotnet:main Nov 25, 2025
156 of 158 checks passed
@dotnet-maestro dotnet-maestro bot mentioned this pull request Nov 26, 2025
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@maraf maraf maraf approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara

Assignees

@ilonatommy ilonatommy

Labels

arch-wasm WebAssembly architecture area-Infrastructure-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ilonatommy @lewing @maraf @pavelsavara @teo-tsirpanis