Disable core dumps in host tests that intentionally crash by elinor-fung · Pull Request #116725 · dotnet/runtime

elinor-fung · 2025-06-16T23:31:59Z

For tests that intentionally crash, we were already clearing out DOTNET_DbgEnableMiniDump/COMPlus_DbgEnableMiniDump, but OS core dumps were still enabled.

In tests that are explicitly throwing an unhandled exception, call into OS APIs to disable dumps for the current process
When launching a command that should have dumps disabled, call ulimit -c 0 before the command (for cases where the test doesn't have control over the process)

In this PR build, we no longer have dump files:
linux-x64
osx-x64

Before - six core dumps created / uploaded:
linux-x64
osx-x64

On Windows, we still have two created/uploaded for Muxer_NonAssemblyWithExeExtension and UnhandledException_BreadcrumbThreadDoesNotFinish. I couldn't find a way to disable dump creation just for the process we were launching.

Fixes #116520

cc @dotnet/appmodel @AaronRobinsonMSFT

dotnet-policy-service · 2025-06-16T23:32:32Z

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Copilot

Pull Request Overview

Disables OS core dumps for tests that intentionally crash by adding a utility to turn off dumps in-process and updating how test commands are launched.

Introduce Utilities.CoreDump.Disable() for Linux/macOS interop disabling of core dumps.
Extend Command with .DisableDumps() to wrap process launches with ulimit -c 0 on *nix.
Update all crash-intent tests to call .DisableDumps() and remove the old expectedToFail parameter.
Include CoreDump.cs in all relevant test asset projects.

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/installer/tests/TestUtils/Command.cs	Added `_disableDumps` flag, `DisableDumps()` method, and wrap in `bash -c "ulimit -c 0 ..."` when launching.
src/installer/tests/HostActivation.Tests/StartupHooks.cs	Replaced `.Execute(expectedToFail: true)` with `.DisableDumps().Execute()`.
src/installer/tests/HostActivation.Tests/SelfContainedAppLaunch.cs	Removed `expectedToFail`, now just `.Execute()`.
src/installer/tests/HostActivation.Tests/NativeHosting/LoadAssemblyAndGetFunctionPointer.cs	Added `.DisableDumps()` before `.Execute()`.
src/installer/tests/HostActivation.Tests/NativeHosting/GetFunctionPointer.cs	Added `.DisableDumps()` before `.Execute()`.
src/installer/tests/HostActivation.Tests/NativeHosting/ApplicationExecution.cs	Added `.DisableDumps()` before `.Execute()`.
src/installer/tests/HostActivation.Tests/InvalidHost.cs	Removed `expectedToFail` param and updated `.Execute()`.
src/installer/tests/HostActivation.Tests/FrameworkDependentAppLaunch.cs	Removed `expectedToFail`, updated `.Execute()`.
src/installer/tests/HostActivation.Tests/DotnetArgValidation.cs	Removed `expectedToFail` and updated `.Execute()`.
src/installer/tests/HostActivation.Tests/DependencyResolution/AdditionalDeps.cs	Removed `expectedToFail` usage and updated `.Execute()`.
src/installer/tests/HostActivation.Tests/Breadcrumbs.cs	Added `.DisableDumps()` before `.Execute()`.
src/installer/tests/Assets/Projects/HelloWorld/SelfContained.csproj	Include `CoreDump.cs` compile item.
src/installer/tests/Assets/Projects/HelloWorld/Program.cs	Call `Utilities.CoreDump.Disable()` in the crash branch.
src/installer/tests/Assets/Projects/HelloWorld/HelloWorld.csproj	Include `CoreDump.cs` compile item.
src/installer/tests/Assets/Projects/CoreDump.cs	New interop utility to disable core dumps on Linux/macOS.
src/installer/tests/Assets/Projects/Component/Component.csproj	Include `CoreDump.cs` compile item.
src/installer/tests/Assets/Projects/Component/Component.cs	Call `Utilities.CoreDump.Disable()` before throwing.
src/installer/tests/Assets/Projects/AppWithCustomEntryPoints/Program.cs	Call `Utilities.CoreDump.Disable()` before throwing.
src/installer/tests/Assets/Projects/AppWithCustomEntryPoints/AppWithCustomEntryPoints.csproj	Include `CoreDump.cs` compile item.

Comments suppressed due to low confidence (1)

src/installer/tests/TestUtils/Command.cs:137

Add an XML doc comment for DisableDumps() to explain that it clears dump‐creation env vars and wraps the process with ulimit -c 0 on Linux/macOS.

        public Command DisableDumps()

src/installer/tests/TestUtils/Command.cs

src/installer/tests/Assets/Projects/CoreDump.cs

Co-authored-by: Copilot <[email protected]>

AaronRobinsonMSFT · 2025-06-18T18:32:25Z

I couldn't find a way to disable dump creation just for the process we were launching.

Setting WER dump count to 0?

AaronRobinsonMSFT · 2025-06-18T18:33:27Z

I couldn't find a way to disable dump creation just for the process we were launching.

Setting WER dump count to 0?

Oh, you meant as in the specific instance rather than all instances of the exe, right?

src/installer/tests/Assets/Projects/CoreDump.cs

elinor-fung · 2025-06-18T21:10:17Z

I couldn't find a way to disable dump creation just for the process we were launching.

Setting WER dump count to 0?

Oh, you meant as in the specific instance rather than all instances of the exe, right?

Yeah, specific instance. I want to leave dumps enabled for any other crashes (the intentionally crashing process is dotnet in these cases).

MichalStrehovsky · 2025-06-19T04:50:26Z

Yeah, specific instance. I want to leave dumps enabled for any other crashes (the intentionally crashing process is dotnet in these cases).

I think this will achieve that:

runtime/src/tests/nativeaot/SmokeTests/ControlFlowGuard/ControlFlowGuard.cs

Lines 67 to 74 in 96e283d

    
           [DllImport("kernel32", ExactSpelling = true)] 
        
           static extern uint GetErrorMode(); 
        
           [DllImport("kernel32", ExactSpelling = true)] 
        
           static extern uint SetErrorMode(uint uMode); 
        
           // Don't pop the WER dialog box that blocks the process until someone clicks Close. 
        
           SetErrorMode(GetErrorMode() | 0x0002 /* NOGPFAULTERRORBOX */);

The NOGPFAULTERRORBOX disables WER for the process.

elinor-fung · 2025-06-19T17:29:18Z

Thanks - I'll try out NOGPFAULTERRORBOX separately. Going to get this in first, since the dumps are killing CI on Linux (but not Windows)

elinor-fung · 2025-06-19T17:29:40Z

/ba-g failure is #116647

elinor-fung added 2 commits June 16, 2025 16:30

Disable core dumps in host tests that intentionally crash

ab3a639

Remove expectedToFail parameter from Command.Execute

b10ff02

elinor-fung added the area-Host label Jun 16, 2025

dotnet-policy-service bot assigned elinor-fung Jun 16, 2025

This was referenced Jun 17, 2025

browser-wasm windows Debug AllSubsets_CoreCLR builds failing in emcc seemingly unrelated to any code issues #116647

Closed

Occasional failure in "browser-wasm windows Release LibraryTests: Build Product" #116671

Closed

Explicitly call 'ulimit -c 0' when launching tests expected to crash

a754a34

build-analysis bot mentioned this pull request Jun 18, 2025

browser-wasm Windows build error #116746

Closed

elinor-fung marked this pull request as ready for review June 18, 2025 00:11

Copilot AI review requested due to automatic review settings June 18, 2025 00:11

Copilot AI reviewed Jun 18, 2025

View reviewed changes

Apply suggestions from code review

94d1c37

Co-authored-by: Copilot <[email protected]>

build-analysis bot mentioned this pull request Jun 18, 2025

Microsoft.DotNet.CoreSetup.Test.HostActivation.FrameworkDependentAppLaunch.AppHost_GlobalLocation fails with "Failed to restore file HelloWorld.exe" #115851

Closed

Update src/installer/tests/TestUtils/Command.cs

9a57aff

Co-authored-by: Copilot <[email protected]>

AaronRobinsonMSFT reviewed Jun 18, 2025

View reviewed changes

src/installer/tests/Assets/Projects/CoreDump.cs Show resolved Hide resolved

Check DbgEnableMiniDump is not set or 0

e61e2ba

AaronRobinsonMSFT approved these changes Jun 18, 2025

View reviewed changes

agocke approved these changes Jun 19, 2025

View reviewed changes

elinor-fung merged commit 37b2daa into dotnet:main Jun 19, 2025
74 of 76 checks passed

elinor-fung deleted the hostTest-expectedCrash branch June 19, 2025 19:11

elinor-fung added this to the 10.0.0 milestone Jun 19, 2025

elinor-fung mentioned this pull request Jun 23, 2025

Disable WER for host test apps that intentionally crash #116936

Merged

github-actions bot locked and limited conversation to collaborators Jul 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Disable core dumps in host tests that intentionally crash#116725

Disable core dumps in host tests that intentionally crash#116725
elinor-fung merged 6 commits intodotnet:mainfrom
elinor-fung:hostTest-expectedCrash

elinor-fung commented Jun 16, 2025 •

edited

Loading

Uh oh!

dotnet-policy-service bot commented Jun 16, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AaronRobinsonMSFT commented Jun 18, 2025

Uh oh!

AaronRobinsonMSFT commented Jun 18, 2025

Uh oh!

Uh oh!

elinor-fung commented Jun 18, 2025

Uh oh!

MichalStrehovsky commented Jun 19, 2025

Uh oh!

elinor-fung commented Jun 19, 2025

Uh oh!

elinor-fung commented Jun 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

elinor-fung commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-service bot commented Jun 16, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AaronRobinsonMSFT commented Jun 18, 2025

Uh oh!

AaronRobinsonMSFT commented Jun 18, 2025

Uh oh!

Uh oh!

elinor-fung commented Jun 18, 2025

Uh oh!

MichalStrehovsky commented Jun 19, 2025

Uh oh!

elinor-fung commented Jun 19, 2025

Uh oh!

elinor-fung commented Jun 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

elinor-fung commented Jun 16, 2025 •

edited

Loading