Conversation
github-actions
bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull Request Overview
Update the expected PCA issuer in the DAC certificate signing script.
- Change the issuer check from “Microsoft Code Signing PCA 2010” to “Microsoft Code Signing PCA 2024”
Comments suppressed due to low confidence (2)
eng/native/sign-with-dac-certificate.ps1:42
- [nitpick] Consider extracting the expected subject and issuer values into named variables or script parameters to avoid hard-coded magic strings and ease future updates.
if ($signingCert.Subject -ne "CN=.NET DAC, O=Microsoft Corporation, L=Redmond, S=Washington, C=US" `
eng/native/sign-with-dac-certificate.ps1:43
- Add or update automated tests to cover the new PCA 2024 issuer value, ensuring the script fails when encountering the old PCA 2010 certificate.
- -or $signingCert.Issuer -ne "CN=Microsoft Code Signing PCA 2024, O=Microsoft Corporation, L=Redmond, S=Washington, C=US")
jkoritzinsky
approved these changes
Jun 10, 2025
mmitche
approved these changes
Jun 11, 2025
This was referenced Jun 12, 2025
Open
Member
Author
|
/ba-g this doesn't get tested in CI. The errors are from the Helix Auth service outages and android timeouts. |
Copilot AI
added a commit
that referenced
this pull request
Dec 26, 2025
…ializers Fix #116507: C# verbatim identifiers like @else are now correctly handled when generating property initializers for init-only properties. The fix changes PropertyInitializerGenerationSpec.Name to use NameSpecifiedInSourceCode (which includes the @ prefix for reserved keywords) instead of MemberName. Also added a unit test to verify this scenario works correctly. Co-authored-by: stephentoub <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.