[Mono][Win] Incorrect decomposition of simd calls#116433
Conversation
|
Tagging subscribers to this area: @steveisok, @vitek-karas |
|
cc: @lateralusX |
|
@saitama951 change seems to trigger some intrinsics error. Maybe we should keep the switch with instructions to decompose if the uses_simd_intrinsics is false. So pretty much add your exclude of the xcall ops in decompose_vtype_opt_uses_simd_intrinsics then keep the check on the uses_simd_intrinsics + the switch to decompose a well known set of SIMD ops as last option. |
75c07fe to
210a2bb
Compare
simd decomposition for OP_ARG cases for simd calls in handled incorrectly currently the decomposition intrinsic takes place based on a xcall but later on this xcall is decomposed into a vcall where the return register is removed. fixes dotnet#116287
|
Done @lateralusX , |
|
I see a failure on windows-x64-release, looks to be unrelated to this change? |
|
@lateralusX can this be merged? |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@lewing - IBM was asking about this one. Do any of the failures need to be handled? |
|
There were a couple of failures not known by the build analysis but they didn't look related so I'm not worried. I merged main if the regular tests look good we can take it. I did run into something similar to the underlying issue in here in another place that that I hacked around |
|
windows CI seems to be green now. |
|
Its a Windows Mono runtime only change, so should only affect the Windows CI lanes. |
|
/ba-g infrastructure timeouts are not related |
simd decomposition for OP_ARG cases for simd calls in handled incorrectly
currently the decomposition intrinsic takes place based on a xcall but later on this xcall is decomposed into a vcall where the return register is removed.
fixes #116287