Skip to content

Replace runtime's 'OutputRID' by the corresponding vmr property 'TargetRid'.#116259

Merged
ViktorHofer merged 1 commit into
dotnet:mainfrom
tmds:targetrid
Jun 3, 2025
Merged

Replace runtime's 'OutputRID' by the corresponding vmr property 'TargetRid'.#116259
ViktorHofer merged 1 commit into
dotnet:mainfrom
tmds:targetrid

Conversation

@tmds

@tmds tmds commented Jun 3, 2025

Copy link
Copy Markdown
Member

@ViktorHofer ptal.

@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Jun 3, 2025
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Comment thread eng/build.sh
;;

-outputrid)
-targetrid|-outputrid)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept the argument for backwards compatibility.

@ViktorHofer ViktorHofer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this a search & replace?

@tmds

tmds commented Jun 3, 2025

Copy link
Copy Markdown
Member Author

Was this a search & replace?

Yes, for the OutputRID to TargetRid and then some manual handling of the remaining outputrid matches (and removing <TargetRid>$(OutputRID)</TargetRid>).

@ViktorHofer ViktorHofer enabled auto-merge (squash) June 3, 2025 16:38
@ViktorHofer ViktorHofer merged commit b4eb528 into dotnet:main Jun 3, 2025
160 of 162 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure community-contribution Indicates that the PR has been added by a community member

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants