Skip to content

Conversation

@richlander
Copy link
Member

Copilot AI review requested due to automatic review settings May 14, 2025 21:50
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 14, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Alpine Edge and Azure Linux 3.0 VM testing legs, increases ARM64 coverage, and standardizes platform definitions.

  • Introduce Alpine Edge variant and Azure Linux 3.0 for ARM64 and x64.
  • Update conditionals to include extra and all-platform builds.
  • Reformat platform sections for consistency.
Comments suppressed due to low confidence (4)

eng/pipelines/libraries/helix-queues-setup.yml:34

  • The alias 'Ubuntu.2504.ArmArch.Open' is inconsistent with the existing 'Ubuntu.2504.Arm64.Open' pattern; consider renaming to 'Ubuntu.2504.Arm64.Open'.
-        - (Ubuntu.2504.ArmArch.Open)[email protected]/dotnet-buildtools/prereqs:ubuntu-25.04-helix-arm64v8

eng/pipelines/libraries/helix-queues-setup.yml:36

  • To match existing conventions, use 'AzureLinux.3.0.Arm64.Open' instead of 'AzureLinux.3.0.ArmArch.Open', and ensure casing is consistent.
-        - (AzureLinux.3.0.ArmArch.Open)[email protected]/dotnet-buildtools/prereqs:azurelinux-3.0-helix-arm64v8

eng/pipelines/libraries/helix-queues-setup.yml:46

  • The 'and' expression has only one argument, causing a syntax error. Change to 'if eq(parameters.platform, 'linux_musl_arm64')' or split into nested conditionals correctly.
-    - ${{ if and(eq(parameters.platform, 'linux_musl_arm64') }}:

eng/pipelines/libraries/helix-queues-setup.yml:54

  • The shorthand 'azurelinux.3.amd64.open' doesn't match the defined alias 'AzureLinux.3.0.Amd64.Open'; use the full container spec or the exact alias.
-          - azurelinux.3.amd64.open

@richlander
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop-linux

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@richlander
Copy link
Member Author

Something seems wrong with CI. Only linker tests were run.

@richlander
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop-linux

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richlander
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop-linux

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richlander
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop-linux

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richlander
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richlander
Copy link
Member Author

Looks like there is one primary break due to these changes in VB tests, from Alpine Edge. The Azure Linux failures appear to be resolved.

System.TypeInitializationException : The type initializer for 'Microsoft.VisualBasic.Tests.FinancialTests' threw an exception.
---- System.FormatException : Failed to parse version string: '3.22.0_alpha20250108'
-------- System.FormatException : The input string '0_alpha20250108' was not in a correct format.

@richlander
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richlander
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop-linux

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richlander
Copy link
Member Author

  • Outerloop failures on Linux look unrelated (and I've seen elsewhere).
  • Extra platform failures are not on Linux

@richlander
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop-linux

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richlander
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop-linux

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richlander
Copy link
Member Author

richlander commented May 19, 2025

Looks like just one Alpine 3.21 issue. Alpine 3.21 isn't new. The only change is the underlying VM, back to Ubuntu (from Azure Linux 3). I could (and will eventually) change it back, but I'm worried that there somehow might be a kernel-specific issue. Hopefully this is just a change that slipped in from main. I'll watch the other PRs to see if it shows up.

@wfurt

    System.Net.Mail.Tests.SmtpClientSendMailTest_SendMailAsync.MultipleRecipients_Failure_All [FAIL]
      Assert.Null() Failure: Value is not null
      Expected: null
      Actual:   ParsedMailMessage { Attachments = [], Body = "body", Cc = "[email protected], [email protected]", ContentType = text/plain; charset=us-ascii, From = "[email protected]", ··· }
      Stack Trace:
        /_/src/libraries/System.Net.Mail/tests/Functional/SmtpClientSendMailTest.cs(310,0): at System.Net.Mail.Tests.SmtpClientSendMailTest`1.MultipleRecipients_Failure_All()
        --- End of stack trace from previous location ---
      Output:
        Server> 220 localhost
        Client> EHLO Da00CREX
        Server> 250-localhost, mock server here
              > 250 AUTH PLAIN LOGIN
        Client> MAIL FROM:<[email protected]>
        Server> 250 Ok
        Client> RCPT TO:<[email protected]>
        Server> 550 unknown recipient
        Client> RCPT TO:<[email protected]>
        Server> 550 unknown recipient
        Client> RCPT TO:<[email protected]>
        Server> 550 unknown recipient
        Client> RCPT TO:<[email protected]>
        Server> 550 unknown recipient
        Client> DATA
        Server> 354 Start mail input; end with <CRLF>.<CRLF>
        Client> MIME-Version: 1.0
              > From: [email protected]
              > To: [email protected], [email protected]
              > Cc: [email protected], [email protected]
              > Date: 19 May 2025 16:04:51 +0000
              > Subject: subject
              > Content-Type: text/plain; charset=us-ascii
              > Content-Transfer-Encoding: quoted-printable
              > 
              > body
              > 
              > .
        Server> 250 Ok: queued as 1219
        Client> QUIT
        Server> 221 Bye
  Finished:    System.Net.Mail.Functional.Tests

@richlander
Copy link
Member Author

Oops. I was wrong. The failure is Arm32 specific, which was unchanged. False alarm.

@richlander
Copy link
Member Author

/ba-g "Linux Arm32 and Windows issue unrelated to this change"

@richlander
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop-linux

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@richlander
Copy link
Member Author

/ba-g "Failures are in test legs that we were not touching"

@richlander richlander enabled auto-merge (squash) May 20, 2025 01:23
@richlander richlander merged commit 9c6be5f into dotnet:main May 20, 2025
115 of 128 checks passed
@richlander richlander deleted the alpine-edge branch May 20, 2025 01:24
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants