Merged
Conversation
ghost
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes Raspbian 10 support by eliminating ARMv6 and Raspbian10-related logic from tests, platform detection utilities, and pipeline configurations. Key changes include:
- Removal of ActiveIssue attributes referencing PlatformDetection.IsArmv6Process and PlatformDetection.IsRaspbian10 in test files.
- Deletion of the IsArmv6Process and IsRaspbian10 properties from PlatformDetection classes.
- Cleanup of pipeline configuration entries and documentation referencing Linux armv6/Raspbian10 images.
Reviewed Changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| System.Net.Requests/tests/ServicePointTests/ServicePointManagerTest.cs | Removed an ActiveIssue attribute for ARMv6 testing. |
| System.Net.Quic/tests/FunctionalTests/MsQuicPlatformDetectionTests.cs | Removed an ActiveIssue referencing Raspbian10 and ARMv6. |
| TestUtilities/System/PlatformDetection.cs | Removed the IsArmv6Process property. |
| TestUtilities/System/PlatformDetection.Unix.cs | Removed the IsRaspbian10 property. |
| eng/pipelines/runtime-community.yml | Removed armv6-related pipeline configuration comments. |
| eng/pipelines/libraries/helix-queues-setup.yml | Removed Linux armv6 helix queue configuration. |
| eng/pipelines/common/templates/pipeline-with-resources.yml | Removed the linux_armv6 image configuration block. |
| eng/pipelines/common/platform-matrix.yml | Removed the linux_armv6 block from the platform matrix. |
| docs/workflow/using-docker.md | Removed the documentation row referencing the Ubuntu 20.04 Arm32 (v6) Raspbian10 image. |
Files not reviewed (2)
- Directory.Build.props: Language not supported
- eng/Subsets.props: Language not supported
Comments suppressed due to low confidence (9)
src/libraries/System.Net.Requests/tests/ServicePointTests/ServicePointManagerTest.cs:286
- Removal of the ActiveIssue attribute for ARMv6 is intentional; please verify that test coverage for ARMv6-specific scenarios is adjusted accordingly.
[ActiveIssue("https://github.com/dotnet/runtime/issues/64674", typeof(PlatformDetection), nameof(PlatformDetection.IsArmv6Process))]
src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicPlatformDetectionTests.cs:59
- Ensure that the removal of ARMv6 and Raspbian10 active issues does not leave unsupported platform test cases unhandled.
[ActiveIssue("https://github.com/dotnet/runtime/issues/82154", typeof(PlatformDetection), nameof(PlatformDetection.IsRaspbian10), nameof(PlatformDetection.IsArmv6Process), nameof(PlatformDetection.IsInContainer))]
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs:68
- Confirm that removal of IsArmv6Process aligns with the overall deprecation of ARMv6 support and that any dependent logic has been updated.
public static bool IsArmv6Process => (int)RuntimeInformation.ProcessArchitecture == 7; // Architecture.Armv6
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Unix.cs:25
- Verify that the complete removal of IsRaspbian10 does not impact Unix-specific test logic and that all references have been updated.
public static bool IsRaspbian10 => IsDistroAndVersion("raspbian", 10);
eng/pipelines/runtime-community.yml:110
- Ensure the removal of armv6 pipeline configurations is consistent across all pipeline definitions and update related documentation if necessary.
- # disable armv6 until https://github.com/dotnet/runtime/issues/104333 is fixed
eng/pipelines/libraries/helix-queues-setup.yml:28
- Confirm that the deletion of the Linux armv6 helix queue configuration is intentional and that no dependent processes require this configuration.
# Linux armv6
eng/pipelines/common/templates/pipeline-with-resources.yml:21
- Ensure removal of the linux_armv6 configuration block is coordinated with the deprecation of ARMv6 support in the pipeline resources.
linux_armv6:
eng/pipelines/common/platform-matrix.yml:45
- Verify that the removal of the linux_armv6 block from the platform matrix does not adversely affect dependent platform build configurations.
# Linux armv6
docs/workflow/using-docker.md:51
- Update documentation to clearly reflect the removal of Ubuntu 20.04 Arm32 (v6) support based on the deprecation of Raspbian 10.
| Ubuntu (x64) | Ubuntu 20.04 | Arm32 (v6) | `mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-20.04-cross-armv6-raspbian-10` | `/crossrootfs/armv6` |
teo-tsirpanis
added
area-Infrastructure
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
This was referenced Apr 29, 2025
Member
|
/ba-g DeadLetter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #115029
Replaces: #115071