[Test Only] Fix Idn tests#115030
Merged
tarekgh merged 4 commits intodotnet:release/8.0-stagingfrom Apr 26, 2025
Merged
Conversation
[Test Only] Port the Idna test fixes to support Unicode 15
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-globalization |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the IDN tests to support Unicode version 16.0 by adding new test data files and updating ICU version checks.
- Adds Unicode_16_0_IdnaTest test class and corresponding data files.
- Updates the ICU version logic in the test Factory to select the appropriate test data file.
- Expands test result constructors to handle additional source information.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Globalization.Extensions/tests/IdnMapping/Data/Unicode_16_0_IdnaTest.cs | Adds new test class for Unicode 16.0 data |
| src/libraries/System.Globalization.Extensions/tests/IdnMapping/Data/Unicode_16_0/ReadMe.txt | Provides updated documentation and metadata for Unicode 16.0 test data |
| src/libraries/System.Globalization.Extensions/tests/IdnMapping/Data/Factory.cs | Modifies ICU version conditions, which may affect the selection of test classes |
| src/libraries/System.Globalization.Extensions/tests/IdnMapping/Data/ConformanceIdnaUnicodeTestResult.cs | Introduces an overloaded constructor for additional test result details |
| src/libraries/System.Globalization.Extensions/tests/IdnMapping/Data/ConformanceIdnaTestResult.cs | Adds a new constructor parameter and enhances dot and hyphen processing |
Files not reviewed (1)
- src/libraries/System.Globalization.Extensions/tests/System.Globalization.Extensions.Tests.csproj: Language not supported
src/libraries/System.Globalization.Extensions/tests/IdnMapping/Data/Factory.cs
Outdated
Show resolved
Hide resolved
carlossanlop
added
Servicing-approved
This was referenced Apr 25, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Test Only] Fix IDN tests