[release/9.0-staging] JIT: revised fix for fp division issue in profile synthesis#115026
Merged
AndyAyersMS merged 2 commits intorelease/9.0-stagingfrom May 8, 2025
Merged
Conversation
The previous fix #113396 could still leave us trying to evaluate 0.0/0.0, which causes an invalid FP operation exception. Make sure the divisor is non-zero.
ghost
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jeffschwMSFT
approved these changes
Apr 24, 2025
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
lgtm. we will take for consideration in 9.0.x
jeffschwMSFT
added
the
Servicing-consider
amanasifkhalid
approved these changes
Apr 25, 2025
JulieLeeMSFT
approved these changes
Apr 25, 2025
rbhanda
added
Servicing-approved
vseanreesermsft
added
Servicing-consider
Member
|
@AndyAyersMS friendly reminder that code complete is on Monday May 12th (2:00 PM Pacific) for the June Release. If you'd like to get this change included in that release, please merge this PR before the deadline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #115005 to release/9.0-staging
/cc @AndyAyersMS
Customer Impact
Unexpected floating-point divide by zero exception. While we generally don't support running managed code with FP exceptions enabled, we also should not be generating such exceptions needlessly.
There is precedent for us back porting this kind of change, see eg: #76334
This is a revised version of a previous fix #113418. The original fix removed the divide by zero case, but allowed for 0.0/0.0, which also causes an FP exception (invalid operation).
Regression
.NET 9 added a fair amount of FP processing to the JIT that wasn't there in .NET 8.
Testing
Verified the JIT will no longer cause any FP exception from this computation.
Risk
Low, no diffs in SPMI.
Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.