When parameter type has [ServiceKey] allow 'object' as the parameter type #114785
Conversation
|
Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection |
| // Assert | ||
| Assert.Equal(42, actualInt.Key); | ||
| Assert.Equal("hello", actualString.Key); | ||
| Assert.Null(notFound); |
There was a problem hiding this comment.
The bool is not registered with AddKeyedTransient(); only int and string are.
| // Act | ||
| var actualInt = serviceProvider.GetKeyedService<ServiceKeyWithObjectTypedArgument>(42); | ||
| var actualString = serviceProvider.GetKeyedService<ServiceKeyWithObjectTypedArgument>("hello"); | ||
| var notFound = serviceProvider.GetKeyedService<ServiceKeyWithObjectTypedArgument>(false); |
There was a problem hiding this comment.
Passing null means that this is not a "keyed service" so it just uses the type which is ServiceKeyWithObjectTypedArgument and since that was not registered, it returns null.
These checks are really just verifying that [ServiceKey] object key is called with the correct key and no unexpected exceptions occur.
tarekgh
left a comment
tarekgh
left a comment
There was a problem hiding this comment.
LGTM. can you think of any breaking can happen because of this change other than allowing the object scenario that used to throw before?
No breaking changes that I can think of. This functionality is just injecting the key used, no lookups or anything, so it's fairly isolated. |
2 participants
When the
[ServiceKey]attribute is applied to a constructor parameter (which sets the parameter value to the key that was used to resolve the service), support usingobjectas the parameter type.Before this PR, the parameter had to be the actual type the service is requested with, even when
AnyKeyis used. With this PR, the parameter can now also beobjectfor both cases where the service is registered as the actual type or registered asAnyKey.Supporting both cases helps decouple the service implementation from the registration key type when the service implementation elects to use
objectas the parameter type with[ServiceKey].Also fixed was a validation issue when
AnyKeywas used withValidateOnBuild=truewhich caused[ServiceKey]not to work at all even if the parameter type was the actual type.Fixes #114780
Fixes #93438