Don't use BaseOS as the RID for publishing NativeAOT'd assets when OutputRID is the SDK's RID #114755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tputRID is the SDK's RID This fixes SourceBuild Stage2 failures in dotnet/sdk#48523
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- src/coreclr/tools/aot/ILCompiler/ILCompiler_publish.csproj: Language not supported
- src/coreclr/tools/aot/crossgen2/crossgen2_publish.csproj: Language not supported
ghost
added
the
jkoritzinsky
added
source-build
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
ViktorHofer
approved these changes
Apr 16, 2025
am11
reviewed
Apr 16, 2025
am11
reviewed
Apr 16, 2025
Member
Author
|
/ba-g nrbf dead letter unrelated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes SourceBuild Stage2 failures currently making all SourceBuild/VMR builds red