Enable jit optimization in crossgen testing by AndyAyersMS · Pull Request #114464 · dotnet/runtime

AndyAyersMS · 2025-04-10T00:55:52Z

Also mark filter test entry point as aggressiveinlining to create a cross-assembly wrapped exception throw test when crossgen2 runs in composite mode.

(see #113815 / #113849)

Also mark `filter` test entry point as `aggressiveinlining` to create a cross-assembly wrapped exception throw test when crossgen2 runs in composite mode. (see dotnet#113815 / dotnet#113849)

Copilot

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)

src/tests/Common/CLRTest.CrossGen.targets: Language not supported
src/tests/JIT/Directed/throwbox/filter.il: Language not supported

AndyAyersMS · 2025-04-10T00:56:38Z

Seems like we should generally run crossgen2 tests with jit optimizations enabled.

@steveisok @jkotas PTAL

AndyAyersMS · 2025-04-10T00:57:05Z

/azp run runtime-coreclr crossgen2 outerloop

azure-pipelines · 2025-04-10T00:57:16Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2025-04-10T03:08:13Z

Also mark filter test entry point as aggressiveinlining

This makes the test fail due to the bug that you are fixing.

jkotas

LGTM if the change does not introduce any new test failures.

AndyAyersMS · 2025-04-10T14:50:58Z

Windows script change has > instead of >>.

There are a bunch of failures of the form

Running R2RDump:  dotnet /root/helix/work/correlation/R2RDump/R2RDump.dll --header --sc --in /root/helix/work/workitem/e/Regressions/coreclr/22021/consumer/composite-r2r.dll --out /root/helix/work/workitem/e/Regressions/coreclr/22021/consumer/composite-r2r.dll.r2rdump --val
Error: System.BadImageFormatException: Failed to convert invalid RVA to offset: 67168
   at ILCompiler.Reflection.ReadyToRun.PEReaderExtensions.GetOffset(PEReader reader, Int32 rva) in /_/src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/PEReaderExtensions.cs:line 113
   at ILCompiler.Reflection.ReadyToRun.ReadyToRunReader.EnsureImportSections() in /_/src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ReadyToRunReader.cs:line 1497
   at R2RDump.TextDumper.DumpSectionContents(ReadyToRunSection section) in /_/src/coreclr/tools/r2rdump/TextDumper.cs:line 435
   at R2RDump.TextDumper.DumpSection(ReadyToRunSection section) in /_/src/coreclr/tools/r2rdump/TextDumper.cs:line 120
   at R2RDump.TextDumper.DumpHeader(Boolean dumpSections) in /_/src/coreclr/tools/r2rdump/TextDumper.cs:line 81
   at R2RDump.Program.Dump(ReadyToRunReader r2r) in /_/src/coreclr/tools/r2rdump/Program.cs:line 166
   at R2RDump.Program.Run() in /_/src/coreclr/tools/r2rdump/Program.cs:line 460
02:52:41

Also this test is probably optimization sensitive

02:40:54.506 Running test: JIT/Directed/debugging/poisoning/poison/poison.dll
Xunit.Sdk.EqualException: Assert.Equal() Failure: Values differ
Expected: 100
Actual:   101
   at Xunit.Assert.Equal[T](T expected, T actual, IEqualityComparer`1 comparer) in /_/src/Microsoft.DotNet.XUnitAssert/src/EqualityAsserts.cs:line 174
   at Program.<<Main>$>g__TestExecutor113|0_114(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&)

AndyAyersMS · 2025-04-10T14:58:43Z

/azp run runtime-coreclr crossgen2 outerloop

azure-pipelines · 2025-04-10T14:58:56Z

Azure Pipelines successfully started running 1 pipeline(s).

AndyAyersMS · 2025-04-10T15:02:07Z

Also mark filter test entry point as aggressiveinlining

This makes the test fail due to the bug that you are fixing.

Yes, want to make sure it actually fails.

Looks like it does:

22:35:51.135 Running test: JIT/Directed/throwbox/filter/filter.dll
inside 1st try
entering filter
System.Runtime.CompilerServices.RuntimeWrappedException: An object that does not derive from System.Exception has been wrapped in a RuntimeWrappedException.
   at Program.<<Main>$>g__TestExecutor28|0_29(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&)
22:35:51.139 Failed test: JIT/Directed/throwbox/filter/filter.dll

AndyAyersMS · 2025-04-10T17:46:14Z

It looks like <CrossGenTest>false</CrossGenTest> is not actually excluding the test. And there are the invalid RVA failures.

So we can't yet enable optimization.

AndyAyersMS · 2025-04-10T20:01:49Z

Going to try just enabling for windows, opened #114504 for the Linux R2R composite issue.

AndyAyersMS · 2025-04-10T20:02:01Z

/azp run runtime-coreclr crossgen2 outerloop

azure-pipelines · 2025-04-10T20:02:15Z

Azure Pipelines successfully started running 1 pipeline(s).

AndyAyersMS · 2025-04-10T22:24:33Z

None of the failures seems related:

Crossgen2 OSX failure is #109395

17:34:55.631 Running test: JIT/opt/Devirtualization/Comparer_get_Default/Comparer_get_Default.dll
Type DoubleEnum: type is HFA but READYTORUN_LAYOUT_HFA flag is not set

Assert failure(PID 3608 [0x00000e18], Thread: 31661 [0x7bad]): Verify_TypeLayout 'DoubleEnum' failed to verify type layout
    File: /Users/runner/work/1/s/src/coreclr/vm/jitinterface.cpp:14041
    Image: /private/tmp/helix/working/B2270958/p/corerun

Wasm failure looks like low-memory / oom

##[warning]Free memory is lower than 5%; Currently used: 95.30%
##[warning]Free memory is lower than 5%; Currently used: 95.30%
##[warning]Free memory is lower than 5%; Currently used: 95.30%
...
  /__w/1/s/dotnet.sh: line 27: 52432 Killed                  ${dotnetPath} "$@"

x86 failure is in tracing/eventpipe/diagnosticport/diagnosticport/diagnosticport.cmd
Opened #114506

	  1.7s: Assert failure(PID 392 [0x00000188], Thread: 4844 [0x12ec]): g_flsIndex != FLS_OUT_OF_INDEXES
	  1.7s: CORECLR! OsDetachThread + 0x23 (0x7218ea20)
	  1.7s: CORECLR! SetThread + 0x64 (0x71d6cb92)
	  1.7s: CORECLR! Thread::DecExternalCount + 0x1E1 (0x71d63d96)
	  1.7s: CORECLR! Thread::OnThreadTerminate + 0x368 (0x71d6a09f)
	  1.7s: CORECLR! DestroyThread + 0xE2 (0x71d64232)
	  1.7s: CORECLR! ep_rt_thread_coreclr_start_func + 0x24 (0x72081164)
	  1.7s: KERNEL32! BaseThreadInitThunk + 0x24 (0x764662c4)
	  1.7s: NTDLL! RtlSubscribeWnfStateChangeNotification + 0x439 (0x76ee08b9)
	  1.7s: NTDLL! RtlSubscribeWnfStateChangeNotification + 0x404 (0x76ee0884)
	  1.7s:     File: D:\a\_work\1\s\src\coreclr\vm\ceemain.cpp:1794
	  1.7s:     Image: C:\h\w\A04C08E0\p\corerun.exe

Enable jit optimization in crossgen testing

5d3f02a

Also mark `filter` test entry point as `aggressiveinlining` to create a cross-assembly wrapped exception throw test when crossgen2 runs in composite mode. (see dotnet#113815 / dotnet#113849)

Copilot AI review requested due to automatic review settings April 10, 2025 00:55

Copilot AI reviewed Apr 10, 2025

View reviewed changes

ghost added the area-crossgen2-coreclr label Apr 10, 2025

dotnet-policy-service bot assigned AndyAyersMS Apr 10, 2025

build-analysis bot mentioned this pull request Apr 10, 2025

CI flakiness: mono interpreter build getting killed #114123

Open

jkotas approved these changes Apr 10, 2025

View reviewed changes

fix script; exclude poisoning test from crossgen

1306d21

undo test change for now

07e7fbb

AndyAyersMS mentioned this pull request Apr 10, 2025

Crossgen2 composite with JitOptimization causes R2R dump failures on linux #114504

Closed

fix test exclusion, don't optimize on Linux yet

73f1033

AndyAyersMS mentioned this pull request Apr 10, 2025

Assertion failure g_flsIndex != FLS_OUT_OF_INDEXES #114506

Closed

AndyAyersMS merged commit 05cd31b into dotnet:main Apr 10, 2025
112 of 118 checks passed

AndyAyersMS mentioned this pull request Apr 10, 2025

Block inlines with different exception wrapping behavior #113849

Merged

github-actions bot locked and limited conversation to collaborators May 11, 2025

Conversation

AndyAyersMS commented Apr 10, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

AndyAyersMS commented Apr 10, 2025

Uh oh!

AndyAyersMS commented Apr 10, 2025

Uh oh!

azure-pipelines bot commented Apr 10, 2025

Uh oh!

jkotas commented Apr 10, 2025

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

AndyAyersMS commented Apr 10, 2025

Uh oh!

AndyAyersMS commented Apr 10, 2025

Uh oh!

azure-pipelines bot commented Apr 10, 2025

Uh oh!

AndyAyersMS commented Apr 10, 2025

Uh oh!

AndyAyersMS commented Apr 10, 2025

Uh oh!

AndyAyersMS commented Apr 10, 2025

Uh oh!

AndyAyersMS commented Apr 10, 2025

Uh oh!

azure-pipelines bot commented Apr 10, 2025

Uh oh!

AndyAyersMS commented Apr 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants